Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change elements mode to activating BIP9 signaling based on height #780

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

instagibbs
Copy link
Collaborator

@instagibbs instagibbs commented Nov 13, 2019

When based on block time, it's really hard to engineer principled tests for activation of consensus changes.

resolves #779

@instagibbs instagibbs added the needs port Needs backport to a different branch label Nov 13, 2019
@apoelstra
Copy link
Member

utACK

@stevenroose
Copy link
Member

ACK 6fc3fe0

stevenroose added a commit that referenced this pull request Nov 14, 2019
…n height

6fc3fe0 Change elements mode to activating BIP9 signaling based on height (Gregory Sanders)

Pull request description:

  When based on block time, it's really hard to engineer principled tests for activation of consensus changes.

  resolves #779

Tree-SHA512: c5672d54a3a906d1318c82197022b9effd39e951e3f9e5ca4dc92055f2fa638a6359797662014c4928be25795ddd6b3f401769d53a967cf08d4f564210926773
@stevenroose stevenroose merged commit 6fc3fe0 into ElementsProject:master Nov 14, 2019
stevenroose added a commit that referenced this pull request Nov 14, 2019
…based on height

27d9a70 Change elements mode to activating BIP9 signaling based on height (Gregory Sanders)

Pull request description:

  backport of #780

Tree-SHA512: 7af5eb4a3a0302141b234a3e818b7188c986efd539825290b70a20e3f2549864d90e65e51d967ec92e7c28d837e690df17bd1f0fe86f50ef071d033111c93f0e
apoelstra added a commit to apoelstra/elements that referenced this pull request Nov 9, 2020
apoelstra added a commit to apoelstra/elements that referenced this pull request Nov 10, 2020
stevenroose pushed a commit that referenced this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs port Needs backport to a different branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend BIP9 to allow block-based signaling window height
3 participants