-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch up with Core until commit f617e05c38c9c7e663b824fefe5329cc5cbbf26a #620
Merged
Merged
Changes from 1 commit
Commits
Show all changes
425 commits
Select commit
Hold shift + click to select a range
ee0b7c4
build: Pin to specific versions of Python packages we install from Py…
practicalswift 23419e4
Merge #14335: net: refactor: cleanup ThreadSocketHandler
laanwj c269209
[tests] Small fixups before deprecating generate
jnewbery b191c7d
doc: add comment explaining recentRejects-DoS behavior
jamesob 27bf14f
Merge #14495: build: Warn (don't fail!) on spelling errors
sipa 3036faf
Merge #14496: build: Pin to specific versions of Python packages we i…
laanwj eeeaa29
descriptors.md: Refer to descriptors as describing instead of matching
ryanofsky 816fab9
Merge #14450: qt: Fix QCompleter popup regression
jonasschnelli 2b91e42
[docs] Add release note for removing getwitnessaddress
jnewbery 041224a
Merge #14472: [doc] getblocktemplate: use SegWit in example
laanwj 9c5f0d5
Merge #13878: utils: Add fstream wrapper to allow to pass unicode fil…
laanwj d98777f
Merge #14146: wallet: Remove trailing separators from -walletdir arg
laanwj 96f6dc9
Avoid triggering undefined behaviour in base_uint<BITS>::bits()
practicalswift 32c5f18
Merge #14177: qt: Set C locale for amountWidget
laanwj fe23553
Merge #14374: qt: Add "Blocksdir" to Debug window
laanwj b6b9915
Textual improvements
merland 369244f
utils: Fix broken Windows filelock
ken2812221 3715b24
Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>…
laanwj bc60c61
Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG
practicalswift aab8172
[tests] Add generate method to TestNode
jnewbery c9f0295
[wallet] Deprecate the generate RPC method
jnewbery 1fb3c16
Add `doc/bitcoin-conf.md`
hebasto fc4db35
wallet: Add ListWalletDir utility
promag d1b03b8
interfaces: Add getWalletDir and listWalletDir to Node
promag cc33773
rpc: Add listwalletdir RPC
promag 0cb3cad
qa: Add tests for listwalletdir RPC
promag d56a068
docs: Add release notes for listwalletdir RPC
promag 321decf
rpc: Fix wallet unload during walletpassphrase timeout
promag 8eb2cd1
Merge #14291: wallet: Add ListWalletDir utility function
laanwj 6d247b1
gitignore contents of db4 folder
murtyjones 33ae985
doc: Update OpenBSD build guide for 6.4
fanquake d387507
Merge #14465: tests: Stop node before removing the notification file
sipa a4edb16
ZMQ: add options to configure outbound message high water mark, aka S…
mruddy 3be209d
rpc: Always throw in getblockstats if -txindex is required
promag 7e18673
Fix typo
kristapsk 8010ded
Merge #14524: Trivial: fix typo
sipa b14db5a
Merge #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_…
sipa b2863c0
Merge #14426: utils: Fix broken Windows filelock
sipa dc1e542
Merge #14474: bitcoin-tx: Use constant for n pubkeys check
sipa e754c6e
Merge #14011: Disable wallet and address book Qt tests on macOS minim…
sipa 91482e5
Merge #14460: tests: Improve 'CAmount' tests
sipa 544f323
Merge #14512: docs: Textual improvements in README.md
sipa 8640631
docs: Document lint tests
d433239
Merge #14456: test: forward timeouts properly in send_blocks_and_test
6746a89
Merge #14497: docs: Add doc/bitcoin-conf.md
laanwj fadffae
Revert "Make qt wallet test compatible with qt4"
8907df9
qa: Ensure wallet unload during walletpassphrase timeout
promag 585b47c
rpc: Prevent concurrent savemempool
promag fa4bcaf
travis: Compile once on xenial
96c409c
Merge #14527: qa: Revert "Make qt wallet test compatible with qt4"
laanwj 43719e0
[macOS] Remove DS_Store WindowBounds bytes object
jonasschnelli 7579560
Merge #13909: validation: Pass chainparams in AcceptToMemoryPoolWorke…
73cddb3
Merge #14526: docs: Document lint tests
5c25409
Merge #14161: doc/descriptors.md tweaks
2c6281f
Add key origin support to descriptors
sipa ff37459
Add tests for key origin support
sipa 8afb166
Update documentation to incude origin information
sipa 96c509e
show the progress of functional test
isghe 38b9850
qt: cleanup: Move BIP70 functions together in paymentserver
laanwj fbb643d
Add BIP70 deprecation warning
jameshilliard 48439b3
Don't link SSL_LIBS with GUI unless BIP70 is enabled
jameshilliard 5918204
Removed explicit mention of storage requirement (squashed)
merland 0a8f519
Merge #14150: Add key origin support to descriptors
sipa b3f377d
Merge #14511: doc: Remove explicit storage requirement from README.md
sipa ab9aca2
[rpc] add 'getnewaddress' hint to 'generatetoaddress' help text.
jnewbery 3668bb3
Merge #14468: [wallet] Deprecate generate RPC method
94cf1ec
Merge #14417: Fix listreceivedbyaddress not taking address as a string
5473e25
Merge #14444: Add compile time checking for cs_main locks which we as…
e895fdc
Merge #11634: wallet: Add missing cs_wallet/cs_KeyStore locks to wallet
9dda5fd
Merge #14296: [wallet] Remove addwitnessaddress
2e15fa1
Merge #12842: Prevent concurrent savemempool
laanwj 9886590
Merge #14451: Add BIP70 deprecation warning and allow building GUI wi…
laanwj a74ed3a
Merge #14453: rpc: Fix wallet unload during walletpassphrase timeout
laanwj 2d796fa
wallet: Fix duplicate fileid
ken2812221 4ea7732
tests: add test case for loading copied wallet twice
ken2812221 6241eb3
Merge #14504: tests: show the progress of functional tests
2b88f67
Merge #14320: [bugfix] wallet: Fix duplicate fileid detection
laanwj 4dca7d0
appveyor: Enable multiwallet test
ken2812221 613fc95
Merge #14559: appveyor: Enable multiwallet tests
f6ed748
Add SegWit support to importmulti with some ProcessImport cleanup
meshcollider 353c064
Fix typo in test_framework/blocktools
meshcollider 1753d21
Add release notes for importmulti segwit change
meshcollider 201451b
Make getaddressinfo return solvability
meshcollider c11875c
Add segwit address tests for importmulti
meshcollider 01a4c09
wallet: Add WalletLocation utility class
promag 65f3672
wallet: Refactor to use WalletLocation
promag fbaccbf
build: Fix Qt link order for Windows build
ken2812221 754a00d
Merge #14416: Fix OSX dmg issue (10.12 to 10.14)
laanwj ed2e183
Remove fs::relative call and fix listwalletdir tests
promag 9d45415
Merge #14518: rpc: Always throw in getblockstats if -txindex is required
laanwj d50c996
Merge #14561: Remove fs::relative call and fix listwalletdir tests
laanwj fa78a2f
[tests] Test that nodes respond to getdata with notfound
ae85c8d
Merge #14568: build: Fix Qt link order for Windows build
f4e4ea1
Merge #13515: travis: Enable qt for all jobs
15db77f
Don't rely on locale dependent functions in base_blob<BITS>::SetHex(.…
practicalswift c70f9c0
Merge #14571: [tests] Test that nodes respond to getdata with notfound
efaf2d8
Merge #13783: validation: Pass tx pool reference into CheckSequenceLocks
36c8e68
Various textual improvements in build docs
merland 04972fe
Remove unused `adjustedTime` parameter
hebasto 643b25d
Merge #14583: docs: Textual improvements in build docs
f1e2f2a
Merge #14585: refactor: remove usage of locale dependent std::isspace
cf2f430
gui: explicitly disable "Dark Mode" appearance on macOS
fanquake d8bf107
Bugfix: RPC: Add address_type named param for createmultisig
luke-jr 29f429d
Merge #14596: Bugfix: RPC: Add address_type named param for createmul…
0e6de3a
added details about commit messages
merland 8711cc0
qt: Improve BitcoinAmountField class
hebasto 4bd125f
tests: Print dots by default
ken2812221 a16f44c
qt: Remove "Pay only required fee" checkbox
hebasto 053b6f4
align items in contrib init
morenoh149 fa77aaa
doc: Add external interface consistency guarantees
0a04667
FreeBSD: Document Python 3 requirement for 'gmake check'
murrayn b312579
Merge #14454: Add SegWit support to importmulti
laanwj 53bb6be
Remove obj_c for macOS Dock icon setting
hebasto 9605bbd
Make clear function argument case in dev notes
dongcarl d38a509
Merge #14600: docs: Clarify commit message guidelines
laanwj 08a57d5
Merge #14593: gui: explicitly disable "Dark Mode" appearance on macOS
laanwj 6a095bc
Merge #14569: tests: Print dots by default in functional tests
9899e65
Merge #14617: FreeBSD: Document Python 3 requirement for 'gmake check'
laanwj f6df989
Merge #14197: [psbt] Convert non-witness UTXOs to witness if witness …
laanwj f69d922
Merge #14592: doc: Add external interface consistency guarantees
laanwj 1e0f3c4
macOS: disable AppNap during sync
krab 5049f7f
Merge #14625: Make clear function argument case in dev notes
laanwj 086fc83
Tests: Fix a comment
raxomukus 3fd7e76
[tests] Move deterministic address import to setup_nodes
jnewbery e4dc39b
Replace platform dependent type with proper const
hebasto bafb921
Remove duplicated code
hebasto 51e5ef3
Merge #14377: check that a separator is found for psbt inputs, output…
laanwj 5352030
Avoid using numeric_limits for sequence numbers and lock times
ryanofsky 5aa31f6
tests: add utility to assert node memory usage hasn't increased
jamesob 62f94d3
tests: add P2PConnection.send_raw_message
jamesob d20a9fa
tests: add tests for invalid P2P messages
jamesob fe5d22b
More concise conversion of CDataStream to string
gwillen 4f3f5cb
Remove redundant txConst parameter to FillPSBT
gwillen 65166d4
New PartiallySignedTransaction constructor from CTransction
gwillen 53e6fff
Add bool PSBTInputSigned
gwillen 0f5bda2
Simplify arguments to SignPSBTInput
gwillen 5655005
Refactor PSBTInput signing to enforce invariant
gwillen e13fea9
Add regression test for PSBT signing bug #14473
gwillen fa43626
test_runner: Remove travis specific code
c34c821
Merge #14631: [tests] Move deterministic address import to setup_nodes
7504157
Merge #14630: test_runner: Remove travis specific code
742ee21
Merge #14528: travis: Compile once on xenial
63c74d2
build: Remove illegal spacing in darwin.mk
ch4ot1c 2464925
Use Qt signal for macOS Dock icon click event
hebasto 6b1d297
Remove obj_c for macOS Dock icon menu
hebasto b740788
Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC
76e13b5
warnings: Compiler warning on memset usage for non-trivial type
ldm5180 2068f08
scripted-diff: Move util files to separate directory.
jimpo bccb4d2
Merge #14555: Move util files to directory
laanwj 13d98ea
Merge #14647: build: Remove illegal spacing in darwin.mk
laanwj 5796671
qt: Add GUIUtil::bringToFront
promag 6fc21ac
qt: Use GUIUtil::bringToFront where possible
promag 0a656f8
qt: All tray menu actions call showNormalIfMinimized
promag 69d574a
Merge #14554: qt: Remove unused `adjustedTime` parameter
laanwj 4ed7308
scripted-diff: Rename misleading 'defaultPort' to 'http_port'
murrayn 46eb275
Merge #14350: Add WalletLocation class
laanwj 15a219f
Merge #14628: Trivial: Rename misleading 'defaultPort' to 'rpc_port'
laanwj 76ae7a1
Merge #14515: doc: Update OpenBSD build guide for 6.4
laanwj 9912486
rpc: Make HTTP RPC debug logging more informative
practicalswift ab8c6f2
Add SAFE_CHARS[SAFE_CHARS_URI]: Chars allowed in URIs (RFC 3986)
practicalswift 45f5006
Merge #14618: rpc: Make HTTP RPC debug logging more informative
laanwj dac2caa
Merge #14060: ZMQ: add options to configure outbound message high wat…
laanwj 73a8408
Merge #14092: tests: Dry run bench_bitcoin as part "make check" to al…
6b8d0a2
Merge #14632: Tests: Fix a comment
b602214
trivial: Don't translate in help text
ken2812221 bbbbb3f
qa: Add test to ensure node can generate all help texts at runtime
4fb789e
Extract CSipHasher to it's own file in crypto/ directory.
jimpo fef5adc
blockfilter: Use unordered_set instead of set in blockfilter.
jimpo 6c5355e
example_test.py: fixup coinbase height argument, derive number clearly
instagibbs dbc1a64
Merge #14660: trivial: Don't translate help texts
9c3f6c5
Merge #14664: example_test.py: fixup coinbase height argument, derive…
9f49db7
Enable functional tests in UBSAN job. Enable -fsanitize=integer (part…
practicalswift 1ba5583
Merge #14252: build: Run functional tests and benchmarks under the un…
13fe258
Error if rpcpassword in conf contains a hash character
meshcollider 0385109
Add test for rpcpassword hash error
meshcollider 99d33a6
appveyor: Script improvement part II
ken2812221 5a05aa2
Add metavar to match var name in help text + Change wording for bette…
merland 825f779
doc: Add historical release notes for 0.17.0.1
laanwj fced6b5
Add UBSan options: print_stacktrace + halt_on_error
practicalswift 024816d
Merge #14522: tests: add invalid P2P message tests
laanwj cdddd17
Merge #14658: qa: Add test to ensure node can generate all rpc help t…
laanwj 5c292da
Add UBSan suppressions needed to pass test suite
practicalswift 880bc72
Merge #14074: Use std::unordered_set instead of set in blockfilter in…
laanwj 7e2e62c
Add skeleton chain and client classes
ryanofsky 8db11dd
Pass chain and client variables where needed
ryanofsky ea961c3
Remove direct node->wallet calls in init.cpp
ryanofsky 79d579f
Remove uses of cs_main in wallet code
ryanofsky 6af27b8
Merge #14619: tests: Fix value display name in test_runner help text
081accb
Pass chain locked variables where needed
ryanofsky 3d305e3
Send fewer spam messages in p2p_invalid_messages
jamesob 4773fa8
Add llvm-symbolizer directory to PATH. Needed to get symbolized stack…
practicalswift 976583e
Merge #14672: tests: Send fewer spam messages in p2p_invalid_messages
d864e45
Merge #14673: travis: Fail the UBSan Travis build in case of newly in…
4e6dc7a
Merge #14665: appveyor: Script improvement part II
66c7024
Merge #14611: docs: align items in contrib init
e8d490f
Merge #14636: Avoid using numeric_limits for sequence numbers and loc…
590a57f
tests: Remove unused testing code
practicalswift c82190c
tests: Add Python dead code linter (vulture)
practicalswift d26d15c
Merge #14365: tests: Add Python dead code linter (vulture) to Travis
fa4da3c
[doc] conf: Remove deprecated options from docs, Other cleanup
7afddfa
importmulti: Don't add internal addresses to address book
instagibbs 11e1ac3
Merge #14436: doc: add comment explaining recentRejects-DoS behavior
7a90b1b
build: Fix windows build error if `--disable-bip70`
ken2812221 6b8d86d
Require a public key to be retrieved when signing a P2PKH input
achow101 4e4de10
Throw error if CPubKey is invalid during PSBT keypath serialization
instagibbs e527810
Merge #14686: build: Fix windows build error if `--disable-bip70`
e70a19e
Merge #14684: [doc] conf: Remove deprecated options from docs, Other …
fa9ed38
test_node: get_mem_rss fixups
cbf0093
Merge #14437: Refactor: Start to separate wallet from node
fa0d36f
rpc: Include rpc/util.h where needed for RPCHelpMan
6c787d3
tests: Make feature_block pass on centos
fa21568
qa: Avoid race in p2p_invalid_block by waiting for the block request
b30c62d
Merge #14588: Refactor PSBT signing logic to enforce invariant and fi…
sipa 16e3b17
Merge #14689: Require a public key to be retrieved when signing a P2P…
sipa edc7152
Merge #12783: macOS: disable AppNap during sync
laanwj fa3df02
travis: Avoid timeout on verify-commits check
fa5a6ce
qa: Raise ci test_runner timeout to 40 mins
ae32806
Merge #14651: Refactor: Fix compiler warning in prevector.h
laanwj 4822325
Merge #14123: gui: Add GUIUtil::bringToFront
laanwj af3c8a7
Merge #14693: test_node: get_mem_rss fixups
laanwj 5cdfd72
Merge #14228: Qt: Enable system tray icon by default if available
laanwj 90c0b6a
Merge #14494: Error if # is used in rpcpassword in conf
laanwj fa483e1
rpc: Add RPCHelpMan for machine-generated help
47ed24c
Merge #14356: fix converttopsbt permitsigdata arg, add basic test
laanwj 27154ce
util.h: explicitly include required QString header
1Il1 b60f4e3
Merge #13381: RPC: creates possibility to preserve labels on importpr…
jonasschnelli 083f535
Merge #14608: qt: Remove the "Pay only required fee..." checkbox
jonasschnelli ce7fcc3
Merge #14690: Throw error if CPubKey is invalid during PSBT keypath s…
laanwj c51e151
Merge #14714: util.h: explicitly include required QString header
laanwj 5d605b2
Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the …
e0c6bb7
Merge #14705: travis: Avoid timeout on verify-commits check
c651265
Merge #14530: Use RPCHelpMan to generate RPC doc strings
f617e05
Merge #14679: importmulti: Don't add internal addresses to address book
laanwj 7f894ae
UPSTREAM MERGE BROKEN: Merge commit 'f617e05c38c9c7e663b824fefe5329cc…
stevenroose 7256637
MERGE-FIX: Makefile fix
stevenroose 9f4f2e7
MERGE-FIX: Fix compilation errors
stevenroose 449ac89
MERGE-FIX: Copy bitcoin_functional from upstream
stevenroose 71723f7
MERGE-FIX: Adapt bitcoin_functional
stevenroose 3a83980
MERGE-FIX: Fix upstream functional tests
stevenroose 1a2a93a
MERGE-FIX: General fixes for functional tests
stevenroose 5492cef
MERGE-FIX: Fix fedpeg and pak tests for 0.18.0
stevenroose ee0e510
MERGE-FIX: Fix other functional tests
stevenroose bf4f1d0
MERGE-FIX: Disable p2p_invalid_messages tests to fix later
stevenroose dc900eb
Merge branch 'master' into catchup
stevenroose 4ed0bb3
Fix dead-code linter issues
stevenroose 872d39f
Prevent Travis from failing when tests are disabled
stevenroose ad3d496
Add extra lock check for OSX build
stevenroose d21e056
Address some linter complaints
stevenroose 3cc7205
Assert that queued checks are non-null
instagibbs 693f206
fill checkqueue_tests vector for completion checking
instagibbs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're using regtest I don't think these are required... I can do a follow-up PR if true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
none of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test later :)