Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vector length calculation for targets in BlindTransaction #545

Merged
merged 1 commit into from
Apr 1, 2019
Merged

fix vector length calculation for targets in BlindTransaction #545

merged 1 commit into from
Apr 1, 2019

Conversation

instagibbs
Copy link
Collaborator

port of #514

@dgpv @instagibbs
fix vector length calculation for targets in BlindTransaction
93f49ed 
the size of surjectionTargets and targetAssetGenerator vectors
was calculated as tx.vin.size()*3, based on the fact that for
each input there might also be up to 2 issuance pseudo-inputs,
but did not take into account that the number of auxiliary generators
may exceed the number of inputs. This fixes the size calculations
by taking into account auxiliary generators supplied beyond vin size.
@instagibbs
Copy link
Collaborator Author

@dgpv

dgpv
dgpv approved these changes Mar 30, 2019
View reviewed changes
Copy link
Contributor

@dgpv dgpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@stevenroose
Copy link
Member

utACK 93f49ed

@stevenroose stevenroose merged commit 93f49ed into ElementsProject:master Apr 1, 2019
stevenroose added a commit that referenced this pull request Apr 1, 2019
@stevenroose
Merge #545: fix vector length calculation for targets in BlindTransac…
6e2751c 
…tion

93f49ed fix vector length calculation for targets in BlindTransaction (Dmitry Petukhov)

Pull request description:

  port of #514

Tree-SHA512: 5e082bb2590c1dde70b67607524d974f435f673777459b638ca10193040b45239fcb4302cc47d4aa7dbd0a25627294e7ca4f11658a4e41cfcd001c8ca51faf3b
delta1 pushed a commit to delta1/elements that referenced this pull request Jul 2, 2023
@hebasto
Merge bitcoin-core/gui#547: Override BitcoinApplication::event() to h…
00f8492 
…andle QEvent::Quit

e7fc506 qt: Override BitcoinApplication::event() to handle QEvent::Quit (Hennadii Stepanov)

Pull request description:

  bitcoin-core/gui#336 introduced a regression when termination requests from a platform are not handled properly.

  This PR fixes this regression. On macOS shutdown after clicking "Quit" in Dock icon menu, and during logout works again.

  Fixes bitcoin-core/gui#545.

ACKs for top commit:
  RandyMcMillan:
    tACK e7fc506
  Sjors:
    tACK e7fc506 (rebased on master) indeed fixes the crash described in ElementsProject#545
  promag:
    Tested ACK e7fc506 on macOS 10.15 with Qt 5.15.2.

Tree-SHA512: 236a483dc0828f22999469e133b8ac9f0b6267ec2a27004c3ebaa967689ddb972ea1fa90c1dd41f3bff3d17bf571a707babcef53bd79fd711fda98cfbf120131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgpv dgpv dgpv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@instagibbs @stevenroose @dgpv