rawissueasset RPC call #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
force-pushed
the
rawissuance_rpc
branch
from
26748c4 to
72683ff
Compare
instagibbs
force-pushed
the
rawissuance_rpc
branch
from
63714d0 to
b9f7ce8
Compare
|
I should add light tests for |
instagibbs
force-pushed
the
rawissuance_rpc
branch
from
b9f7ce8 to
b989fd9
Compare
|
Added contract/sequential tests, fixed unexpected behavior of the contract argument expecting hex string. |
instagibbs
force-pushed
the
rawissuance_rpc
branch
from
b989fd9 to
7515536
Compare
|
Changed return value for RPC call to be a list of objects with issuance details, added basic tests. |
|
Realized the wallet is possible appending tokens to vector beyond the fee output, which is always the last output by wallet default. Will fix. |
instagibbs
force-pushed
the
rawissuance_rpc
branch
from
7515536 to
87fb1e2
Compare
|
fixed the output pushing fee output issue |
instagibbs
commented
Dec 2, 2018
src/rpc/rawtransaction.cpp
Outdated
| { | ||
| if (request.fHelp || request.params.size() != 2) | ||
| throw runtime_error( | ||
| "rawissueasset transaction [{\"asset_amount\":x.xxx, \"asset_address\":\"address\", \"token_amount\":x.xxx, \"token_address\":\"address\", \"blind\":bool}, ...]\n" |
instagibbs
commented
Dec 2, 2018
src/rpc/rawtransaction.cpp
Outdated
| } | ||
|
|
||
| CAmount token_amount = 0; | ||
| const UniValue& token_amount_uni = find_value(issuance_o, "token_amount"); |
There was a problem hiding this comment.
switch from find_value to direct access for style
|
I'm going to switch the contract argument to a contract hash, passed in as hex string. This will streamline the reissuance call. |
Merged
instagibbs
force-pushed
the
rawissuance_rpc
branch
from
87fb1e2 to
ca383ac
Compare
|
Pushed update addressing some of @stevenroose comments as well as converting the contract argument to a hash. |
|
tACK ca383ac |
instagibbs
added a commit
that referenced
this pull request
Dec 12, 2018
ca383ac add functional testing for raw issuance call (Gregory Sanders) a5e1af5 rawissueasset RPC call (Gregory Sanders) f9f91ba Fixup issueasset help results information (Gregory Sanders) 69d8d15 Break out issuance-specific testing to its own functional test (Gregory Sanders) 2b22b6d Fixup (raw)blindrawtransaction (Gregory Sanders) a5e9e0e Fix blinding logic for issuances on input 1 or higher (Gregory Sanders) 83df289 fixup BlindTransaction issuance counting assertion (Gregory Sanders) Pull request description: Resolves the initial issuance portion of: #471 The user follows this flow: `createrawtransaction->fundrawtransaction->rawissueasset->blindrawtransaction->signrawtransaction` `rawissueasset` is a new RPC call that allows the user to append N-many issuances, up to the amount of inputs the transaction has, at once. It allows the issuances to be "marked" for blinding later(only effects reissance token asset id), and for the destination outputs to be arbitrary addresses, blinded or otherwise. Previously `fundrawtransaction` would not blind issuances(pretty much on accident), so I have added an argument, default `true`, on whether to blind issuances, since there is no field in the transaction itself to mark as whether we want to blind it or not. Note: This will cause your transactions' fee-rate to go down, so the caller may want to over-shoot fees during the `fundrawtransaction` call as cushion. I also fixed a couple bugs on the way as I uncovered them. Tree-SHA512: fa77158c390743f579797d426b9d9cb000a5d686a8b10aa818b1e9ad65fdc42ac139a36ad226e31676b3bd9c6643bc69074869d6a927309a7ec328c91e853bec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the initial issuance portion of: #471
The user follows this flow:
createrawtransaction->fundrawtransaction->rawissueasset->blindrawtransaction->signrawtransactionrawissueassetis a new RPC call that allows the user to append N-many issuances, up to the amount of inputs the transaction has, at once. It allows the issuances to be "marked" for blinding later(only effects reissance token asset id), and for the destination outputs to be arbitrary addresses, blinded or otherwise.Previously
fundrawtransactionwould not blind issuances(pretty much on accident), so I have added an argument, defaulttrue, on whether to blind issuances, since there is no field in the transaction itself to mark as whether we want to blind it or not.Note: This will cause your transactions' fee-rate to go down, so the caller may want to over-shoot fees during the
fundrawtransactioncall as cushion.I also fixed a couple bugs on the way as I uncovered them.