Fix peg functional test compatability with Core 0.17 #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK |
|
@instagibbs Can I incorporate this in #415 perhaps? |
|
Yeah, Can we rebase this on top of #415 ? |
|
That's ok I guess but with #415 I might just push to delete this test altogether |
|
this test no longer exists, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues fixed:
Implemented a cross-compatible version until we ratchet support to 0.17+ only post-rebase.
validateaddressis deprecated, allowing use for now until we want to ratchet to Core 0.17 only support. Worse case this will happen after rebase of Elements to 0.17.