Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use blinders you don't control the inputs to #231

Closed
wants to merge 1 commit into from
Closed

Don't use blinders you don't control the inputs to #231

wants to merge 1 commit into from

Conversation

instagibbs
Copy link
Collaborator

Previous behavior would use blinders it memorized from previous sends to account for its own blinding.

@jtimon jtimon added the 0.14.1 label Oct 10, 2017
@jtimon jtimon added 0.14.1 and removed 0.14.1 labels Oct 16, 2018
@instagibbs instagibbs added the needs port Needs backport to a different branch label Mar 25, 2019
@instagibbs
Copy link
Collaborator Author

This still seems useful, needs port?

@instagibbs
Copy link
Collaborator Author

instagibbs commented Mar 29, 2019 •
edited
Loading

Tests are perma-failing mysteriously. Maybe just port this and close?

@stevenroose
Copy link
Member

Travis runs this tests on top of latest elements-0.14.1, right? Not on top of the branch the moment you PRd?..

So this should work. I restarted tests. Still want this backported?

@instagibbs
Copy link
Collaborator Author

Ported to master is fine.

@stevenroose stevenroose mentioned this pull request Apr 3, 2019
Merged
instagibbs added a commit that referenced this pull request Apr 4, 2019
@instagibbs
Merge #562: Don't blind with blinding factors that aren't ours
ec62262 
030811b Don't blind with blinding factors that aren't ours (Steven Roose)

Pull request description:

  Cherry-pick of #231.

Tree-SHA512: 14a2e83891edc244ebc1c5cd9a095c0b4914df72f17462cfca2600f6da208f250cc315e91c2ac9232bd6a5197f2d9854cdfeef6ffafdaf36acc51d555c6c13c7
@apoelstra
Copy link
Member

Are we planning to backport this or can we close it?

@stevenroose
Copy link
Member

I think it can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.14.1 needs port Needs backport to a different branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@instagibbs @stevenroose @apoelstra @jtimon