Refactor: Easier support for chains with multiple genesis assets #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the scriptPubKey for signing blocks never changes, there's no point in repeating it with every block header.
Using Bitcoin genesis mainnet hash for pegged-bitcoin asset id was a mistake in the first place.
jtimon
force-pushed
the
e13-multi-genesis
branch
from
82e266d to
104d073
Compare
jtimon
force-pushed
the
e13-multi-genesis
branch
from
104d073 to
d7f11c5
Compare
|
quick read ACK |
3 tasks
|
Replaced by #191 |
gwillen
pushed a commit
that referenced
this pull request
Jun 1, 2022
…-sort Peers table 986bf78 qt: Emit dataChanged signal to dynamically re-sort Peers table (Hennadii Stepanov) Pull request description: [By default](https://doc.qt.io/qt-5/qsortfilterproxymodel.html#details), the `PeerTableSortProxy` > dynamically re-sorts ... data whenever the original model changes. That is not the case on master (8cdf917) as in ecbd911 (#164) no signals are emitted to notify about model changes. This PR uses a dedicated [`dataChanged`](https://doc.qt.io/qt-5/qabstractitemmodel.html#dataChanged) signal. Fixes #367. An alternative to #374. ACKs for top commit: jarolrod: ACK 986bf78 Tree-SHA512: dcb92c2f9a2c632880429e9528007db426d2ad938c64dfa1f1538c03e4b62620df52ad7daf33b582976c67b472ff76bc0dae707049f4bbbd4941232cee9ce3d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some POC chains may be interested in having more than one genesis asset for spiking the additional step of issuing a second asset (or more) for a particular demonstration. Presumably they would copy and modify CElementsParams to create their own chain.
For the 2 way peg, as a next step, a multiasset chain can support pegs to the same parent chain with different federation scripts, or even pegged to different parent chains. We don't support that yet, but in the same way this makes testing that kind of extension easier to test without needing to issue new pegged assets during the tests. Issuing them on the fly can be a next step.
Intentionally, the new "feature" isn't tested, for that would require either a "genesis block id HF" or a new chain. I would prefer if that is done in a later PR (see jtimon/elements@e13-multi-genesis...jtimon:e13-multi-genesis-test for a WIP) and this is merged without testing first purely on the grounds that the behavior should remain perfectly equivalent and if at any point this is not the case for this PR, it should be nacked by reviewers.
Dependencies: