Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac Installer alignment is off #724

Closed
allenpiscitello opened this issue Sep 27, 2019 · 1 comment · Fixed by #786
Closed

Mac Installer alignment is off #724

allenpiscitello opened this issue Sep 27, 2019 · 1 comment · Fixed by #786
Labels
bug GUI regarding Qt GUI

Comments

@allenpiscitello
Copy link
Contributor

Screen Shot 2019-09-27 at 3 17 31 PM

Screen Shot 2019-09-27 at 3 00 40 PM
@instagibbs instagibbs added bug GUI regarding Qt GUI labels Sep 27, 2019
@instagibbs
Copy link
Collaborator

Issue is likey here https://github.com/ElementsProject/elements/blob/master/contrib/macdeploy/custom_dsstore.py

Bitcoin-Qt.app doesn't exist

@philippem philippem mentioned this issue Nov 20, 2019
Merged
instagibbs added a commit that referenced this issue Nov 20, 2019
@instagibbs
Merge #786: macos: Use correct application name
fe27ef8 
60ea625 macos: Use correct application name (Philippe McLean)

Pull request description:

  fixes #724
  - generated DS_Store for dmg was referencing Bitcoin-Qt instead
  of the locally built application Elements-Qt

  ![image](https://user-images.githubusercontent.com/565792/69210165-b9085480-0b0e-11ea-80f5-6acef74d6929.png)

Tree-SHA512: d526b3ff1962e6c968b42ee77d9fb659bef4714195b2fb2dccfdac6443ed33789bc6d9f2edf7803dc78b93b29b5033b5e44811c7e94a3acea880043c12f1a89d
stevenroose pushed a commit to stevenroose/elements that referenced this issue Dec 12, 2019
@philippem @stevenroose
macos: Use correct application name
192620c 
fixes ElementsProject#724
- ds_store was referencing Bitcoin-Qt instead
of built application Elements-Qt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug GUI regarding Qt GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

macos: Use correct application name philippem/elements
2 participants
@instagibbs @allenpiscitello