Throw error if CPubKey is invalid during PSBT keypath serialization

ElementsProject · Nov 8, 2018 · 4e4de10 · 4e4de10
1 parent 6b8d0a2
commit 4e4de10
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/script/sign.h b/src/script/sign.h
@@ -206,6 +206,9 @@ template<typename Stream>
 void SerializeHDKeypaths(Stream& s, const std::map<CPubKey, KeyOriginInfo>& hd_keypaths, uint8_t type)
 {
     for (auto keypath_pair : hd_keypaths) {
+        if (!keypath_pair.first.IsValid()) {
+            throw std::ios_base::failure("Invalid CPubKey being serialized");
+        }
         SerializeToVector(s, type, MakeSpan(keypath_pair.first));
         WriteCompactSize(s, (keypath_pair.second.path.size() + 1) * sizeof(uint32_t));
         s << keypath_pair.second.fingerprint;