Add feature simplicity #68
Conversation
LeoComandini
force-pushed
the
2024-01-15-simplicity-feat
branch
from
9b00e2c to
d9b3caf
Compare
| @@ -37,6 +37,7 @@ pub enum TapTree<Pk: MiniscriptKey, Ext: Extension = NoExt> { | |||
| // are of Leafversion::default | |||
| Leaf(Arc<Miniscript<Pk, Tap, Ext>>), | |||
| /// A taproot leaf denoting a spending condition in terms of Simplicity | |||
| #[cfg(feature = "simplicity")] | |||
| SimplicityLeaf(Arc<simplicity::Policy<Pk>>), | |||
There was a problem hiding this comment.
In d5c0d65320816bfdf36411feed4bdff0708b5b12:
We can't make an enum variant dependent on a feature-gate like this because it will make adding the feature a breaking change for anyone trying to match on the enum.
Our choices are either to mark the enum #[non_exhaustive] (probably the easiest thing for now) or to create a dummy simplicity module when the simplicity feature is disabled, that will include a dummy simplicity::Policy so that this can still compile with the variant present but no Simplicity library.
There was a problem hiding this comment.
In d9b3caf, sorry. Not sure what that other hash is.
There was a problem hiding this comment.
marked the enums #[non_exhaustive]
rust-simplicity is still evolving and it might need fixes or interface changes. Make it optional.
LeoComandini
force-pushed
the
2024-01-15-simplicity-feat
branch
from
d9b3caf to
b80cb46
Compare
|
Neat, TIL that you can match exhaustively on a |
rust-simplicityis still evolving and it might need fixes or interface changes. Make it optional.