Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BEM more robust #27

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Make BEM more robust #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
040c069
[style] Force uniform style
xymopen May 17, 2019
bb0787b
[fix] Make BEM more robust
xymopen Mar 28, 2019
57ecb61
[refactor]: Move nesting to bem-extend()
xymopen Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 21 additions & 32 deletions src/mixins/function.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,43 +2,32 @@

/* BEM support Func
-------------------------- */
@function selectorToString($selector) {
$selector: inspect($selector);
$selector: str-slice($selector, 2, -2);
@return $selector;
}

@function containsModifier($selector) {
$selector: selectorToString($selector);

@if str-index($selector, $modifier-separator) {
@return true;
} @else {
@return false;
}
}
/// See [Combinators](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Selectors#Combinators "CSS selectors")
$_selector-combinators: ("+", "~", ">", "||");

@function containWhenFlag($selector) {
$selector: selectorToString($selector);
@function bem-extend($selectors, $extendees, $extender) {
$returns: ();

@if str-index($selector, '.' + $state-prefix) {
@return true
} @else {
@return false
@if null == $selectors {
$selectors: selector-parse("");
}
}

@function containPseudoClass($selector) {
$selector: selectorToString($selector);

@if str-index($selector, ':') {
@return true
} @else {
@return false
@each $selector in $selectors {
$len: length($selector);

@if index($extendees, nth($selector, $len)) != null {
@if $len < 2 {
$returns: append($returns, ($extender), "comma");
} @else if index($_selector-combinators, nth($selector, $len - 1)) == null {
$returns: append($returns, set-nth($selector, $len, $extender), "comma");
} @else {
$returns: append($returns, append($selector, $extender), "comma");
}
} @else {
$returns: append($returns, append($selector, $extender), "comma");
}
}
}

@function hitAllSpecialNestRule($selector) {

@return containsModifier($selector) or containWhenFlag($selector) or containPseudoClass($selector);
@return $returns;
}
145 changes: 75 additions & 70 deletions src/mixins/mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,112 +53,118 @@
-------------------------- */
@mixin placeholder {
&::-webkit-input-placeholder {
@content
@content;
}

&::-moz-placeholder {
@content
@content;
}

&:-ms-input-placeholder {
@content
@content;
}
}

/* BEM
-------------------------- */

$_BEM: (null, null, null);

@mixin b($block) {
$B: $namespace+'-'+$block !global;
$lastBEM: $_BEM;
$_BEM: ($block, null, null) !global;

.#{$B} {
.#{$namespace}-#{$block} {
@content;
}

$_BEM: $lastBEM !global;
}

@mixin e($element) {
$E: $element !global;
$selector: &;
$currentSelector: "";
@each $unit in $element {
$currentSelector: #{$currentSelector + "." + $B + $element-separator + $unit + ","};
}
@mixin e($elements) {
$block: nth($_BEM, 1);
$old-elements: nth($_BEM, 2);

@if hitAllSpecialNestRule($selector) {
@at-root {
#{$selector} {
#{$currentSelector} {
@content;
}
}
}
@if null == $block {
@error "Base-level rules cannot contain an element mixin";
} @else {
@at-root {
#{$currentSelector} {
@content;
}
}
}
}
$lastBEM: $_BEM;
$_BEM: ($block, $elements, null) !global;

@mixin m($modifier) {
$selector: &;
$currentSelector: "";
@each $unit in $modifier {
$currentSelector: #{$currentSelector + & + $modifier-separator + $unit + ","};
}
$parents: ();

@at-root {
#{$currentSelector} {
@content;
@if (null == $old-elements) {
$parents: append($parents, ".#{$namespace}-#{$block}");
} @else {
@each $element in $old-elements {
$parents: append($parents, ".#{$namespace}-#{$block}#{$element-separator}#{$element}");
}
}
}
}

@mixin configurable-m($modifier, $E-flag: false) {
$selector: &;
$interpolation: '';
$current: ();

@if $E-flag {
$interpolation: $element-separator + $E-flag;
}
@each $element in $elements {
@each $parent in $parents {
$current: append(
$current,
bem-extend(&, $parent, ".#{$namespace}-#{$block}#{$element-separator}#{$element}"),
"comma",
);
}
}

@at-root {
#{$selector} {
.#{$B+$interpolation+$modifier-separator+$modifier} {
@at-root {
#{$current} {
@content;
}
}

$_BEM: $lastBEM !global;
}
}

@mixin spec-selector($specSelector: '', $element: $E, $modifier: false, $block: $B) {
$modifierCombo: '';
@mixin m($modifiers) {
$block: nth($_BEM, 1);
$elements: nth($_BEM, 2);
$old-modifiers: nth($_BEM, 3);

@if $modifier {
$modifierCombo: $modifier-separator + $modifier;
}
@if null == $block {
@error "Base-level rules cannot contain a modifier mixin";
} @else if null != $old-modifiers {
@error "Modifier-level rules cannot contain another modifier mixin";
} @else {
$lastBEM: $_BEM;
$_BEM: ($block, $elements, $modifiers) !global;

@at-root {
#{&}#{$specSelector}.#{$block+$element-separator+$element+$modifierCombo} {
@content
$parents: ();

@if (null == $elements) {
$parents: append($parents, ".#{$namespace}-#{$block}");
} @else {
@each $element in $elements {
$parents: append($parents, ".#{$namespace}-#{$block}#{$element-separator}#{$element}");
}
}
}
}

@mixin meb($modifier: false, $element: $E, $block: $B) {
$selector: &;
$modifierCombo: '';
$current: ();

@if $modifier {
$modifierCombo: $modifier-separator + $modifier;
}
@each $modifier in $modifiers {
@each $parent in $parents {
$current: append(
$current,
bem-extend(&, $parents, "#{$parent}#{$modifier-separator}#{$modifier}"),
"comma",
);
}
}

@at-root {
#{$selector} {
.#{$block+$element-separator+$element+$modifierCombo} {
@content
@at-root {
#{$current} {
@content;
}
}

$_BEM: $lastBEM !global;
}
}

Expand All @@ -178,13 +184,12 @@
$rule-name: '%shared-'+$name;

@at-root #{$rule-name} {
@content
@content;
}
}

@mixin pseudo($pseudo) {
@at-root #{&}#{':#{$pseudo}'} {
@content
@content;
}
}