tooltip和loading组件vue实例创建出来后没有销毁，有内存泄漏问题 #13988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for element ready! Built with commit 63134f4 |
|
@qpxtWhite 感谢你的 PR，是否可以提供一下内存泄漏的例子。或者提供更多细节，帮助我理解和这个 PR |
island205
approved these changes
Jan 18, 2019
|
@island205 很抱歉，最近一直在尝试复现逻辑，将这两个组件从项目中抽离出来单独测试时，并没有发现内存问题； |
|
@qpxtWhite 我也看了挺久，复现不出来，但是从代码上看确实有问题，需要 destroy，所以代码会合并。 |
ziyoung
approved these changes
Jan 23, 2019
3 tasks
weisiren168
pushed a commit
to weisiren168/element
that referenced
this pull request
Jun 20, 2019
lzq4047
pushed a commit
to lzq4047/element
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.