Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: fix a 'activeName' attribute init bug #1100

Closed
wants to merge 1 commit into from
Closed

Tabs: fix a 'activeName' attribute init bug #1100

wants to merge 1 commit into from

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Nov 16, 2016

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's Contributing Guide.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@Kingwl
Copy link
Contributor Author

Kingwl commented Nov 16, 2016

#1034

@@ -14,7 +14,8 @@
return {
children: null,
activeTab: null,
currentName: 0
currentName: 0,
inited: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

但起来并不需要放在 data 里

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来不放在data里面不会重新渲染

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦 是为了强制触发更新么,有一个 $forceUpdate 方法嘛

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

囧 忘了 那删掉好了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants