-
Notifications
You must be signed in to change notification settings - Fork 123
bindings/rust: update bindgen version #4991
Conversation
1fa1cb1
to
cb1e868
Compare
Thx, worked for me, I published the 0.11.1 packages. Let us see if this now fixed the overall problem, afaik the initial problem was that libmodbus needed bindgen 0.55.1 and somehow @fel115 had troubles using it together with the different version of bindgen Elektra was using. I created ElektraInitiative/opensesame#67 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
With the new release everything is working now 👍 |
Is it expected that the macOS builds don't work or how can I fix them? Should we close this issue when ElektraInitiative/opensesame#67 is done? |
Only the Jenkins job is non-optional. The error there seems to be a spurious problem. It can be retriggered with commenting @atmaxinger will you review and merge? |
jenkins build libelektra please |
I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new PR with the remainder of this PR. |
I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new PR with the remainder of this PR. |
Update
bindgen
for rust bindings to 0.66.1 #4989.bindgen
changed some defaults regarding the equality ofusize
andsize_t
. They added the option.size_t_is_usize(true)
but made it defaulttrue
in a later version. When bumping thebindgen
versionthe error goes away. Read more about this in this issue and also here.
Basics
(added as entry in
doc/news/_preparation_next_release.md
which contains_(my name)_
)Please always add them to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels