Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Docker images and packaging for CentOS and openSUSE #4036

Merged
merged 29 commits into from
Sep 28, 2021

Conversation

robaerd
Copy link
Member

@robaerd robaerd commented Sep 12, 2021

This PR contains following:

  • Docker images for for openSuse 15.3 and CentOS 8 Stream
  • Enables packaging for openSuse 15.3 and CentOS 8 Stream
  • Release and master packaging for openSuse 15.3
  • Some updates on INSTALL.md

Discussed in #3519 and #3716

Basics

These points need to be fulfilled for every PR:

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
  • The PR is rebased with current master.

If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

Labels

If you are already Elektra developer:

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and you also
    say that everything is ready to be merged.

@markus2330
Copy link
Contributor

Great to see this! 🚀

@robaerd robaerd marked this pull request as ready for review September 26, 2021 20:20
@mpranj mpranj added this to the 0.9.8 milestone Sep 27, 2021
@robaerd robaerd changed the title Add Docker images for CentOS and openSUSE Docker images and packaging for CentOS and openSUSE Sep 27, 2021
Copy link
Member

@mpranj mpranj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! 🚀

@mpranj mpranj merged commit e46ff03 into ElektraInitiative:master Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants