This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Add the KEY_END marker on key creation where missing #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, great suggestions. Forgetting this caused errors for me numberless times |
| @@ -186,7 +186,7 @@ void test_constructor() | |||
| { | |||
| cout << "testing constructor" << endl; | |||
|
|
|||
| ckdb::Key *ck = ckdb::keyNew(0); | |||
| ckdb::Key *ck = ckdb::keyNew(0, KEY_END); | |||
There was a problem hiding this comment.
If you look at src/libelektra/key.c 275 keyNew(0) should be perfectly valid, because without a name va_start is not executed. Did you have a crash on those lines?
There was a problem hiding this comment.
You're right, these changes were unneeded.
Add the KEY_END vararg where missing when creating a new key, either using the C keyNew or the C++ kdb::Key, as done everywhere else. This fixes crashes in some tests.
markus2330
pushed a commit
that referenced
this pull request
Aug 10, 2014
Add the KEY_END marker on key creation where missing
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the KEY_END vararg where missing when creating a new key, either
using the C keyNew or the C++ kdb::Key, as done everywhere else.
This fixes crashes in some tests.