Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Fix ARM builds #3763

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Fix ARM builds #3763

merged 2 commits into from
Apr 8, 2021

Conversation

mpranj
Copy link
Member

@mpranj mpranj commented Apr 8, 2021

Closes #3450.

@markus2330
Copy link
Contributor

Thank you so much for finally fixing this 👍

Do you need help for testing? (Basically we are not in a hurry, so Harald can also test after the release and if there is still a problem we fix it in the next release.)

@mpranj
Copy link
Member Author

mpranj commented Apr 8, 2021

Unfortunately it was basically done a long time ago. I was just unable to test it due to a broken OpenWRT SDK at the time. (and the SDK was broken for quite some time)

I now tested with a new OpenWRT SDK locally and it builds successfully.

One remaining problem is: the OpenWRT package/Makefile for Elektra is at 0.9.2 and will need to be updated. Lots of gone plugins (tcl, path, ini which was the default storage) and so on. I just did a dirty fix by removing everything and replacing ini with toml, so I could test the build.

I think it's better if Harald fixes the package for real and maybe tests the changes (when we release 0.9.5). I am not an OpenWRT user and I don't have the capacity to always test it. We should definitely ping him when the release is done.

One takeaway could also be: it could be beneficial to add some kind of ARM builds for testing.

@markus2330
Copy link
Contributor

Thank you so much that you even tried to compile OpenWRT to fix the issue. I am in contact with Harald and will tell him after the release. Can you post the package/Makefile which compiled somewhere so that he can pick it up?

One takeaway could also be: it could be beneficial to add some kind of ARM builds for testing.

Yes, definitely. It is on the (unfortunately very long) TODO list of @robaerd #3519
We should try to take less of @robaerd's time so that he can do more of this TODO list 😉

@mpranj mpranj added this to the 0.9.5 milestone Apr 8, 2021
@mpranj
Copy link
Member Author

mpranj commented Apr 8, 2021

I agree @robaerd has done excellent work ❤️ and we should let him focus more on his list.

@mpranj mpranj merged commit 97d945d into ElektraInitiative:master Apr 8, 2021
@mpranj mpranj deleted the kdb_long_double_t branch April 21, 2021 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.9.2: internalnotification uses kdb_long_double_t without checking
2 participants