-
Notifications
You must be signed in to change notification settings - Fork 123
Conversation
Co-authored-by: Mihael Pranjić <[email protected]>
Co-authored-by: Mihael Pranjić <[email protected]>
so that all vars fit on my screen
I read through the release notes again with how the website gets rendered and fixed several more things. Otherwise this PR is like #3638, which can be closed after this is merged. This will most probably be the last commits from me today. |
@@ -157,7 +159,7 @@ The 0.9.\* series of Elektra is for development of Elektra 1.0. | |||
Elektra 1.0 will be incompatible to 0.8 and as such, we need a SO version bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment actually refers to line 146:
Is there a reason why the the RPM instruction are in the DEB instructions block? They both also begin with 2.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to shorten it even more but I agree it might be a bit confusing. Note that it actually renders 2x "2.", so it is somewhat clear that only one of the second steps should be done. But please feel free to improve, simply push to this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the installation guide a bit, I'm not sure if the additional headers are the right way, but it looks IMO a bit more structured. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually misunderstood which text belongs to DEB and what to RPM. Thank you for fixing it!
Thank you both so much! |
Basics
These points need to be fulfilled for every PR:
(added as entry in
doc/news/_preparation_next_release.md
whichcontains
_(my name)_
)Please always add something to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.
Checklist
Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.
(not in the PR description)
Review
Reviewers will usually check the following:
Labels
If you are already Elektra developer:
say that everything is ready to be merged.