Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Release notes #3544

Merged
merged 2 commits into from
Oct 31, 2020
Merged

Release notes #3544

merged 2 commits into from
Oct 31, 2020

Conversation

markus2330
Copy link
Contributor

Basics

These points need to be fulfilled for every PR:

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy.
  • The PR is rebased with current master.

If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

Labels

If you are already Elektra developer:

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and you also
    say that everything is ready to be merged.

Copy link
Member

@mpranj mpranj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it's looking great! I hope the website is rebuilt quickly.

@@ -222,7 +221,7 @@ The [hashsums are:](https://github.com/ElektraInitiative/ftp/blob/master/release
- sha1: 02900ef5c8b24cf067930068c62f2ff09b44354d
- sha256: 5022a6ebf004d892ded03fcf6eb3d223942a7fadd2d68f14d847d1f7f243e1d7

The release tarball is also available signed by Markus Raab using GnuPG from
The release tarball is also available signed by Mihael Pranjić using GnuPG from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

I think it makes no sense chaning the template now. Depending on the automated releases we might use a different signature for the next release anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the website is rebuilt quickly.

Maybe we need an extra pipeline (and step during releases) for that? I added a line in #3536.

I think it makes no sense changing the template now. Depending on the automated releases we might use a different signature for the next release anyway.

Yes, we should directly change the template towards the full automation.

@mpranj mpranj merged commit 36c4ce1 into master Oct 31, 2020
@markus2330 markus2330 deleted the release_notes branch October 31, 2020 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants