Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Release preparation for version 0.9.3 #3535

Closed

Conversation

robaerd
Copy link
Member

@robaerd robaerd commented Oct 28, 2020

This PR updates all necessary files for the 0.9.3 release.

Basics

These points need to be fulfilled for every PR:

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy.
  • The PR is rebased with current master.

If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

Labels

If you are already Elektra developer:

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and you also
    say that everything is ready to be merged.

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can push these commits directly on master. Creating an PR without adapting the release notes is only useful for discussions but not for checking something, as then the build jobs abort very early.

@mpranj
Copy link
Member

mpranj commented Oct 29, 2020

As there is a WIP label I assumed @robaerd will push more changes, or is this done from your side?

@robaerd
Copy link
Member Author

robaerd commented Oct 29, 2020

@mpranj I added the WIP label because you mentioned in #3530 that you will push additional changes on top of it. I will close this PR and push directly to master. Sorry for the confusion.

@robaerd robaerd closed this Oct 29, 2020
@markus2330 markus2330 mentioned this pull request Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants