-
Notifications
You must be signed in to change notification settings - Fork 123
quickdump v2: relative key names, reused buffer, etc. #2501
Conversation
Thank you for the fix! It is much better to have relative key names, see also #51. |
From https://travis-ci.org/ElektraInitiative/libelektra/jobs/507354465#L1741:
@markus2330 How should I fix that? The |
Sync is one of the essential plugins which should always be present. In #423 we discussed about how to improve without risking data loss. So at the moment it would be best if the sync plugin is included in every build job. @sanssecours Do you know why the sync plugin is not included? |
Yes. I excluded sync and all other non-essential plugins to improve the runtime of |
If we want to only include essential plugins in
(the list of plugins available at the time of your commit which you didn't exclude) Instead of starting with |
I explicitly excluded the old (and tested) plugins, since I wanted to make sure newly added plugins (that do not depend on any of the excluded plugins) are tested by |
Thank you! |
A small PR with some changes to quickdump. We now only store relative key names, to enable relocation. We also reuse the buffer on
kdbGet
, for a minor speed-up.@markus2330 please review my pull request