Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

quickdump v2: relative key names, reused buffer, etc. #2501

Merged
merged 19 commits into from
Mar 19, 2019

Conversation

kodebach
Copy link
Member

A small PR with some changes to quickdump. We now only store relative key names, to enable relocation. We also reuse the buffer on kdbGet, for a minor speed-up.

@markus2330 please review my pull request

@markus2330
Copy link
Contributor

Thank you for the fix! It is much better to have relative key names, see also #51.

@kodebach
Copy link
Member Author

From https://travis-ci.org/ElektraInitiative/libelektra/jobs/507354465#L1741:

No plugin that provides sync could be found

@markus2330 How should I fix that? The sync plugin is excluded for the Travis GCC ASAN job (I don't know why), should I re-include it or should I exclude quickdump? (locally GCC ASAN works, if the sync plugin is there) Or is there something I can do, so that sync isn't required?

@markus2330
Copy link
Contributor

Sync is one of the essential plugins which should always be present. In #423 we discussed about how to improve without risking data loss. So at the moment it would be best if the sync plugin is included in every build job.

@sanssecours Do you know why the sync plugin is not included?

@sanssecours
Copy link
Member

Do you know why the sync plugin is not included?

Yes. I excluded sync and all other non-essential plugins to improve the runtime of 🐧 GCC ASAN.

@kodebach
Copy link
Member Author

Yes. I excluded sync and all other non-essential plugins to improve the runtime of 🐧 GCC ASAN.

If we want to only include essential plugins in 🐧 GCC ASAN shouldn't we use:

-DPLUGINS='dump;fstab;haskell;jni;journald;list;lua;python;python2;regexdispatcher;resolver;ruby;simpleini;spec;typechecker;xerces'

(the list of plugins available at the time of your commit which you didn't exclude)

Instead of starting with ALL and excluding a whole bunch of plugins?

@sanssecours
Copy link
Member

…Instead of starting with ALL and excluding a whole bunch of plugins?

I explicitly excluded the old (and tested) plugins, since I wanted to make sure newly added plugins (that do not depend on any of the excluded plugins) are tested by 🐧 GCC ASAN.

@markus2330 markus2330 merged commit d2b9a6d into ElektraInitiative:master Mar 19, 2019
@markus2330
Copy link
Contributor

Thank you!

@kodebach kodebach deleted the qd-rel branch May 27, 2019 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants