-
Notifications
You must be signed in to change notification settings - Fork 123
Haskell: Configure Package Twice #1869
The head ref may contain hidden characters: "\u{1F3D7}"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your maintenance work!
@@ -99,7 +99,7 @@ Some file formats such as [YAML](http://yaml.org) already support Base64 encoded | |||
|
|||
The diagram below shows how the Base64 conversion process works in conjunction with the YAML CPP plugin. | |||
|
|||
![Tree](./base64/Base64.pdf) | |||
![Tree](./Base64.pdf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also make it lower-case, see #1615
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, you can keep it that way. It seems like getting everything lower-case is impossible anyway. (e.g. README.md, CMakeLists.txt, ...)
2 from 3 pdfs are starting with upper-case 👍
@@ -437,7 +437,7 @@ bool checkArgument (std::vector<std::string> const & arguments, std::string test | |||
{ | |||
return arguments.size () == 1 || find (arguments.begin (), arguments.end (), testname) != arguments.end (); | |||
} | |||
} | |||
} // namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this written manually by you or does the code formatter yield different results?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Format 6.0+ adds and corrects these comments if the option FixNamespaceComments
is set to true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #1828
jenkins build all please // seems like just adding me to the admin list was not enough for the builder to pick it up. you will have to rerun tests yourself |
Before this commit Travis would report a missing Python 3 executable in the configuration step on macOS: python3: command not found .
This update fixes a problem on the Travis build server, where `cabal build` would fail printing the following error message: > Saved package config file is outdated > … > re-run the 'configure' command. .
This commit closes ElektraInitiative#1868.
This commit closes ElektraInitiative#1828.
Why was this branch deleted without follow up? Some where nice things have been there. |
I was (and still am) fed up with the current behavior/state of the Jenkins build server. I guess I will reopen this PR after the situation improves. |
Sorry for these inconveniences. I am sure the build server is now in much better hands thanks to @ingwinlu |
would be only be done in clang > 6 but not in clang 5 thanks to @sanssecours, see #1869
thanks to @sanssecours, see #1869
I just pushed the remaining changes in this PR to the |
Purpose
This update fixes a problem on the Travis build server, where
cabal build
would fail printing the following error message:. This issue seems to have nothing to do with caching, as I can reproduce the problem on my local machine too.
Checklist