Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Haskell: Configure Package Twice #1869

Closed
wants to merge 9 commits into from

Conversation

sanssecours
Copy link
Member

Purpose

This update fixes a problem on the Travis build server, where cabal build would fail printing the following error message:

Saved package config file is outdated

re-run the 'configure' command.

. This issue seems to have nothing to do with caching, as I can reproduce the problem on my local machine too.

Checklist

  • I checked all commit messages. The issue reference in commit 944c81a should be correct.
  • I ran all tests and everything went fine.
  • The PR also adds comments about the changes in commit b3533d1.

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your maintenance work!

@@ -99,7 +99,7 @@ Some file formats such as [YAML](http://yaml.org) already support Base64 encoded

The diagram below shows how the Base64 conversion process works in conjunction with the YAML CPP plugin.

![Tree](./base64/Base64.pdf)
![Tree](./Base64.pdf)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make it lower-case, see #1615

Copy link
Contributor

@markus2330 markus2330 Mar 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you can keep it that way. It seems like getting everything lower-case is impossible anyway. (e.g. README.md, CMakeLists.txt, ...)

2 from 3 pdfs are starting with upper-case 👍

@@ -437,7 +437,7 @@ bool checkArgument (std::vector<std::string> const & arguments, std::string test
{
return arguments.size () == 1 || find (arguments.begin (), arguments.end (), testname) != arguments.end ();
}
}
} // namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this written manually by you or does the code formatter yield different results?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clang-Format 6.0+ adds and corrects these comments if the option FixNamespaceComments is set to true.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #1828

@markus2330 markus2330 mentioned this pull request Mar 30, 2018
2 tasks
@ingwinlu
Copy link
Contributor

ingwinlu commented Mar 30, 2018

jenkins build all please // seems like just adding me to the admin list was not enough for the builder to pick it up. you will have to rerun tests yourself

Before this commit Travis would report a missing Python 3 executable in
the configuration step on macOS:

    python3: command not found

.
This update fixes a problem on the Travis build server, where
`cabal build` would fail printing the following error message:

> Saved package config file is outdated
> …
> re-run the 'configure' command.

.
@markus2330
Copy link
Contributor

Why was this branch deleted without follow up? Some where nice things have been there.

@sanssecours
Copy link
Member Author

Why was this branch deleted without follow up?

I was (and still am) fed up with the current behavior/state of the Jenkins build server. I guess I will reopen this PR after the situation improves.

@markus2330
Copy link
Contributor

Sorry for these inconveniences.

I am sure the build server is now in much better hands thanks to @ingwinlu

markus2330 pushed a commit that referenced this pull request Mar 31, 2018
would be only be done in clang > 6 but not in clang 5
thanks to @sanssecours, see #1869
markus2330 pushed a commit that referenced this pull request Mar 31, 2018
@sanssecours
Copy link
Member Author

I just pushed the remaining changes in this PR to the master branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants