Kdb mount #1745
Kdb mount #1745
Conversation
to not fail on existing mountpoints
"--strategy unchanged" as discussed #1306 seems to be buggy: e.g. if plugins add plugin config (like dump) parent keys disappear and it seems like the config was changed (although it was not)
|
jenkins build all please |
There was a problem hiding this comment.
Thank you for fixing issue #1306. Everything looks good as far as I can tell. I would prefer that mounting an already existing mountpoint (with the same configuration) would just work without adding the additional switch -f though. For example, I would expect the following two commands
kdb mount config.ini /examples/ini ini
kdb mount config.ini /examples/ini inito not cause any problems at all. That might just be my preference though.
One thing I also noticed was that there is no (Markdown Shell Recorder) test for the new behavior of kdb mount. It would be very nice if you could also add a test for kdb mount -f.
Yes, I see it the same way. The problem is that it does not always work smoothly (for cases where plugins modify their config and INI is unable to store parent dirs). Thus I would prefer to have it as a separate switch until we get a reliable behavior. Other issues (like INI crashes) are imho more important for this release. |
Adds mount/dini features as discussed in #1693 and #1306
Checklist
Please only check relevant points.
For docu fixes, spell checking and similar nothing
needs to be checked.
@sanssecours please review my pull request