-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup assets and jar META-INF #351
Comments
The manifest file of the release Jar must also be updated in order to publish the mode to Maven Central. |
We should first define a folder layout and then rearrange the files to that scheme and after that we can create a useful inclusion filter. The gradle script should not just copy folders into the jar, we could define different rules for different kinds of files and for example move all models into the same target folder. Another thing that bothers me is that we have to list each model to load in Eln.java. If we have an intelligent data scheme, we could just load all models from a folder at startup. Would be much easier IMHO. |
I think we have to discuss of this point all together in a meeting... |
Prepare to publish on jCenter. Related to #351
…lease jar. Ignore files not used in Minecraft to reduce the release jar size. Related to #351
Prepare to publish on jCenter. Related to #351
…lease jar. Ignore files not used in Minecraft to reduce the release jar size. Related to #351
I made this issue regarding the commit ebba414 from @lambdaShade. The
asset
folder included in the mod realasejar
maybe need some cleanup. IMO, it looks ok now.I think the size of the release
jar
file is not a really big issue... Theassets/eln
folder contains 619 files (~ 4Mo). Currently, every models are included in the release file, event if they are not used in the game.I check the asset folder content. here are some open questions:
model\_Common
needed ?relay800
andRelayBig
replicator/replicator.tcn
used ?stoneCache
model ?TemperatureSensor/myTex - Copie.png
needed ?VoltageSensor/myTex - Copie.png
needed ?export_block.png
,export_cable.png
andexport_sixNodeWall.png
should not be included in the release jar, correct ?items/miaou.png
anditems/tiningot.png
needed ?As proposed by @cm0x4D, I will setup a new filter for the asset folder. Only
.png
,obj
,mtl
,txt
files must be included for the models,ogg
for the sounds,lang
for languages andpng
for all textures and sprites.The text was updated successfully, but these errors were encountered: