-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⛏️ Fix Key Selection Page and Upgrade to MUI 5 #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eslintrc.json" and "BaseConfig https://stackoverflow.com/a/70790903/40783
SteveMaier-IRT
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Supports #87
Description
This fixes the key selection page in election setup and upgrades the package formerly known as Material UI, now rebranded to MUI. It also upgrades all packages that were producing security warnings in npm. The MUI upgrade is a major effort and isn't 100% complete yet. There are still a couple of warnings, but it's a huge improvement and removes a number of runtime warnings that we had been receiving. I'll fix the remaining upgrade issues (e.g. the
adaptV4Theme
shim intheme.js
) in subsequent PR's.Testing
Expected, something like this:
It should list keys (if they exist in the back-end), and they should be selectable.