Fix: catastrophic backtracking and esbuild platform #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 82.14% 82.14%
=======================================
Files 46 46
Lines 1960 1960
Branches 465 440 -25
=======================================
Hits 1610 1610
Misses 348 348
Partials 2 2
Continue to review full report at Codecov.
|
nickreese
approved these changes
Mar 2, 2022
| @@ -155,7 +155,7 @@ const svelteHandler = async ({ elderConfig, svelteConfig, replacements, restartH | |||
| }, | |||
| format: 'esm', | |||
| target: ['es2020'], | |||
| platform: 'node', | |||
| platform: 'browser', | |||
There was a problem hiding this comment.
So obvious. Thank you for the good catch here.
| @@ -35,7 +35,7 @@ describe('#mountComponentsInHtml', () => { | |||
|
|
|||
| mountComponentsInHtml.default({ | |||
| page, | |||
| html: `<div class="svelte-datepicker"><div class="ejs-component" data-ejs-component="Datepicker" data-ejs-props="{ "a": "b" }" data-ejs-options="{ "loading": "lazy" }"></div></div>`, | |||
| html: `<div class="svelte-datepicker"><div class="ejs-component" data-ejs-component="Datepicker" data-ejs-props="{ "a": "b" }" data-ejs-options="{ "loading": "lazy" }"></div></div>`, | |||
There was a problem hiding this comment.
This is indeed correct as the props and options come out of JSON.stringify and escapeHtml in inlineSvelteComponent.ts then are reversed during the mounting process. TY
|
A performance test is added. You can observe the performance issue with following commands: # run the performance test
npx jest src/partialHydration/__tests__/mountComponentsInHtml.spec.ts
# use old regex and run again. It will hang and eat up your CPU
git checkout master -- src/partialHydration/mountComponentsInHtml.ts
npx jest src/partialHydration/__tests__/mountComponentsInHtml.spec.ts |
nickreese
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
Fixes #219