feat(1314737): [Boost] Add Proportional Attribute Component to the Fi… #219
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import React, { useState } from 'react' | ||
| import { ComponentMeta, ComponentStory } from '@storybook/react' | ||
| import ProportionalToAttributesComponent, { | ||
| IProportionalToAttributesValue, | ||
| } from './ProportionalToAttributes' | ||
|
|
||
| export default { | ||
| title: 'Molecules/ProportionalToAttributesComponent', | ||
| component: ProportionalToAttributesComponent, | ||
| } as ComponentMeta<typeof ProportionalToAttributesComponent> | ||
|
|
||
| const Template: ComponentStory<typeof ProportionalToAttributesComponent> = ( | ||
| args | ||
| ) => { | ||
| const [value, setValue] = useState<IProportionalToAttributesValue>({ | ||
| source_field_code: undefined, | ||
| boost_impact: undefined, | ||
| scale_factor: 1, | ||
| }) | ||
| return ( | ||
| <ProportionalToAttributesComponent | ||
| {...args} | ||
| value={value} | ||
| onChange={(value): void => setValue(value)} | ||
| /> | ||
| ) | ||
| } | ||
|
|
||
| export const ProportionalToAttributes = Template.bind({}) | ||
|
|
||
| ProportionalToAttributes.args = { | ||
| boostImpactOptions: [ | ||
| { | ||
| label: 'Low', | ||
| value: 'Low', | ||
| }, | ||
| { | ||
| label: 'Medium', | ||
| value: 'Medium', | ||
| }, | ||
| { | ||
| label: 'High', | ||
| value: 'High', | ||
| }, | ||
| ], | ||
| sourceFields: [ | ||
| { | ||
| label: 'test', | ||
| value: 'test', | ||
| }, | ||
| ], | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| import React from 'react' | ||
| import RadioGroup from '../../atoms/form/RadioGroup' | ||
| import InputText from '../../atoms/form/InputText' | ||
| import DropDown from '../../atoms/form/DropDown' | ||
| import { styled } from '@mui/material' | ||
| import { IOptions } from '@elastic-suite/gally-admin-shared' | ||
| import { useTranslation } from 'next-i18next' | ||
|
|
||
| const Container = styled('div')(({ theme }) => ({ | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| gap: theme.spacing(1), | ||
| })) | ||
|
There was a problem hiding this comment. si possible mettre les styled components dans un fichier à part |
||
|
|
||
| export interface IProportionalToAttributesValue { | ||
| source_field_code?: string | ||
| boost_impact?: string | ||
| scale_factor: number | ||
| } | ||
|
|
||
| export interface IProportionalToAttributesProps { | ||
| sourceFields: IOptions<string> | ||
| boostImpactOptions: IOptions<string> | ||
| value: IProportionalToAttributesValue | ||
| showError?: boolean | ||
| onChange: (value: IProportionalToAttributesValue) => void | ||
| } | ||
|
|
||
| function ProportionalToAttributes({ | ||
| value, | ||
| sourceFields, | ||
| boostImpactOptions, | ||
| showError, | ||
| onChange, | ||
| }: IProportionalToAttributesProps): JSX.Element { | ||
| const { | ||
| source_field_code: sourceFieldCode, | ||
| boost_impact: boostImpact, | ||
| scale_factor: scaleFactor, | ||
| } = value | ||
| const { t } = useTranslation('boost') | ||
|
|
||
| function handleChange( | ||
| name: keyof IProportionalToAttributesValue, | ||
| newValue: string | number | ||
| ): void { | ||
| onChange({ | ||
| ...value, | ||
| [name]: newValue, | ||
| }) | ||
| } | ||
|
|
||
| return ( | ||
| <Container> | ||
| <DropDown | ||
| options={sourceFields} | ||
| label={t('boostConfig.sourceField')} | ||
| value={sourceFieldCode} | ||
| onChange={(value: string): void => | ||
| handleChange('source_field_code', value) | ||
| } | ||
| required | ||
| showError={showError} | ||
| sx={{ minWidth: '230px' }} | ||
| placeholder={t('boostConfig.sourceField.placeholder')} | ||
| /> | ||
|
|
||
| <RadioGroup | ||
| options={boostImpactOptions} | ||
| // todo: pourquoi set la defaultValue et non la value ? | ||
| defaultValue={boostImpact} | ||
| value={boostImpact} | ||
| onChange={(value: string): void => handleChange('boost_impact', value)} | ||
| label={t('boostConfig.boostImpact')} | ||
| required | ||
| showError={showError} | ||
| /> | ||
|
|
||
| <InputText | ||
| type="number" | ||
| label={t('boostConfig.scaleFactor')} | ||
| required | ||
| inputProps={{ | ||
| min: 1, | ||
| }} | ||
| value={scaleFactor} | ||
| onChange={(value: number): void => handleChange('scale_factor', value)} | ||
| showError={showError} | ||
| /> | ||
| </Container> | ||
| ) | ||
| } | ||
|
|
||
| export default ProportionalToAttributes | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import React, { useMemo } from 'react' | ||
| import { useApiList, useResource } from '../../../hooks' | ||
| import ProportionalToAttributes, { | ||
| IProportionalToAttributesProps, | ||
| } from './ProportionalToAttributes' | ||
| import { IOption } from '@elastic-suite/gally-admin-shared' | ||
|
|
||
| function ProportionalToAttributesManager( | ||
| props: Omit< | ||
| IProportionalToAttributesProps, | ||
| 'sourceFields' | 'boostImpactOptions' | ||
| > | ||
| ): JSX.Element { | ||
| const rowsPerPage = 200 | ||
| const sourceFieldFixedFilters = useMemo( | ||
| () => ({ | ||
| 'metadata.entity': 'product', | ||
| }), | ||
| [] | ||
| ) | ||
|
There was a problem hiding this comment. si ça ne change jamais, tu peux déclarer ces variables à l'extérieur du composant (et du coup sans le useMemo) |
||
|
|
||
| const boostImpactOptionResource = useResource('BoostImpactOption') | ||
| const boostAttributeValueFieldOptionsResource = useResource( | ||
| 'BoostAttributeValueFieldOption' | ||
| ) | ||
|
|
||
| const [boostImpactOptionsResponse] = useApiList<IOption<string>>( | ||
| boostImpactOptionResource, | ||
| false, | ||
| rowsPerPage, | ||
| undefined, | ||
| undefined, | ||
| false, | ||
| true | ||
| ) | ||
|
|
||
| const [boostAttributeValueFieldOptionsResponse] = useApiList<IOption<string>>( | ||
| boostAttributeValueFieldOptionsResource, | ||
| false, | ||
| rowsPerPage, | ||
| sourceFieldFixedFilters, | ||
| undefined, | ||
| false, | ||
| true | ||
| ) | ||
|
|
||
| if ( | ||
| !boostImpactOptionsResponse?.data || | ||
| !boostAttributeValueFieldOptionsResponse?.data | ||
| ) { | ||
| return null | ||
| } | ||
|
|
||
| return ( | ||
| <ProportionalToAttributes | ||
| sourceFields={ | ||
| boostAttributeValueFieldOptionsResponse.data['hydra:member'] | ||
| } | ||
| boostImpactOptions={boostImpactOptionsResponse.data['hydra:member']} | ||
| {...props} | ||
| /> | ||
| ) | ||
| } | ||
|
|
||
| export default ProportionalToAttributesManager | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
si tu veux éviter le ternaire tu peux faire comme ce que tu as fait à la ligne 41: