perf: avoid queries when foreign keys are empty

ElMassimo · Nov 4, 2022 · 9f4c0c8 · 9f4c0c8
1 parent 9fa32a0
commit 9f4c0c8
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/mongoid/includes/association/eager.rb b/lib/mongoid/includes/association/eager.rb
@@ -9,7 +9,11 @@ module Eager
         # Internal: Performs eager load and iterates over the preloaded documents
         # for the current relation.
         def each_loaded_document
-          @association.load_documents_for(key, keys_from_docs).each do |doc|
+          foreign_key_values = keys_from_docs
+
+          return @association.klass.none if foreign_key_values.empty?
+
+          @association.load_documents_for(key, foreign_key_values).each do |doc|
             yield doc
           end
         end