Added yank function #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Array/extensions.js
Outdated
| this.remove(value); | ||
| return value; | ||
| } else{ | ||
| throw "Value not in the array"; |
There was a problem hiding this comment.
I think it'd be better to just return a null if there is nothing found in the yank. That way if it was going to be used in a if statement, or a tertiary statement it could be used like if(foo.yank(2)). Here it'd just throw a crazy uncaught error.
| @@ -50,6 +50,30 @@ extensionArray.remove = function remove(selector) { | |||
| return this; | |||
| }; | |||
|
|
|||
| /** | |||
| * Remove all instances of a value within the array and return the removed value | |||
| * @param {*} value - The value trying to match against | |||
There was a problem hiding this comment.
Return value in JSDoc :)
| @@ -68,6 +68,22 @@ describe('array prototype', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('Array yank prototype', () => { | |||
| it('should return removed values and mutate the array ', () => { | |||
There was a problem hiding this comment.
Maybe test for the not found instance as well 👍
|
Oops! @decarbonite Been distracted by real life, I'll try and get to this later tonight 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29