Remove andino_gz_classic and andino_apps references #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusSilvaUtrera
requested review from
francocipollone and
jballoffet
as code owners
Signed-off-by: JesusSilvaUtrera <[email protected]>
|
@francocipollone @jballoffet This is the first one of the 2 PRs to complete the initial Jazzy migration. This shouldn't need too much time to review, the other one is where we will need to test with the robot. |
|
When this PR is merged I will open the other one, I still need to try it locally with the new rebase. |
|
@francocipollone can you merge this one? I still don't have write access to do that, thanks and sorry for the inconveniences! |
jballoffet
pushed a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: JesusSilvaUtrera <[email protected]>
jballoffet
added a commit
that referenced
this pull request
Sep 17, 2024
* Updates CHANGELOG. Signed-off-by: Franco Cipollone <[email protected]> * 0.2.0 * Updates README.md Signed-off-by: Franco Cipollone <[email protected]> * Adds reference to andino_rmf repo (#263) Signed-off-by: Franco Cipollone <[email protected]> * Include robot assembly (#267) * Added all necessary changes to the README Signed-off-by: JesusSilvaUtrera <[email protected]> * Removed a blank line Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: JesusSilvaUtrera <[email protected]> * Remove andino_gz_classic and andino_apps references (#259) Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> Co-authored-by: Franco Cipollone <[email protected]> Co-authored-by: Franco Cipollone <[email protected]> Co-authored-by: Jesús Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
This is part of the migration to Jazzy
Summary
This PR is just a simple modification removing the references to
andino_gz_classic(deprecated because there is no support on ubuntu 24 for Gazebo Classic) andandino_apps(no reason to keep it, demos will be stored somewhere else).Test it
Take a look at the changes.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.