Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves andino_navigation package. #224

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

francocipollone
Copy link
Collaborator

🎉 New feature

Related to #190

Summary

Goes on top of #223 which facilitates nav2 integration on real robot

  • Add readme to explain andino_navigation package use
  • Minor tuning of parameters, mainly reducing inflation radius as the robot is small per sei.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Outdated Show resolved Hide resolved
jballoffet
jballoffet previously approved these changes Feb 14, 2024
Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from francocipollone/use_default_topics to humble February 14, 2024 12:56
@francocipollone francocipollone dismissed jballoffet’s stale review February 14, 2024 12:56

The base branch was changed.

Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone francocipollone force-pushed the francocipollone/nav2_tune branch from 65f6851 to fcf9388 Compare February 14, 2024 12:59
@francocipollone francocipollone merged commit 34b23af into humble Feb 14, 2024
4 checks passed
@francocipollone francocipollone deleted the francocipollone/nav2_tune branch February 14, 2024 13:26
jballoffet added a commit that referenced this pull request Jun 17, 2024
* Improves andino_navigation package. (#224)

Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: JesusSilvaUtrera <[email protected]>

* Add basic Platform IO instructions (#229)

Signed-off-by: Gary Servin <[email protected]>
Signed-off-by: JesusSilvaUtrera <[email protected]>

* Modify Shell class API to allow dependency injection (#221)

Signed-off-by: Javier Balloffet <[email protected]>
Signed-off-by: JesusSilvaUtrera <[email protected]>

* Fixed wheel diameter in URDF (#93)

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Added YAML file for default camera intrinsics (#169)

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Adds references to o3de and isaac_sim simulations. (#232)

Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: JesusSilvaUtrera <[email protected]>

* Added README for andino_bringup (#233)

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Added binaries installation docs (#234)

Signed-off-by: JesusSilvaUtrera <[email protected]>

* andino_apps package created and andino_navigation package updated (#235)

* andino_apps package created and andino_navigation package updated

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Minor changes from the PR

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Update andino_navigation README with changes from PR

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Add andino_apps package to ci.yaml

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Fixed minor issues from the PR

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Added 'andino_apps' to the general README

Signed-off-by: JesusSilvaUtrera <[email protected]>

---------

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Minimal change to test launch file

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Added webcam.yaml file and intrinsics are now publishing

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Added raspicam.yaml with camera intrinsics and updated instructions in andino_hardware/README

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Changed the 'camera_info_url' to be relative path

Signed-off-by: JesusSilvaUtrera <[email protected]>

---------

Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: JesusSilvaUtrera <[email protected]>
Signed-off-by: Gary Servin <[email protected]>
Signed-off-by: Javier Balloffet <[email protected]>
Co-authored-by: Franco Cipollone <[email protected]>
Co-authored-by: Gary Servin <[email protected]>
Co-authored-by: Javier Balloffet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants