Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes USB port names #143

Merged
merged 5 commits into from
Sep 3, 2023
Merged

Fixes USB port names #143

merged 5 commits into from
Sep 3, 2023

Conversation

francocipollone
Copy link
Collaborator

🎉 New feature

Closes #45

Summary

  • Fixes USB port names to
    • ttyUSB_ARDUINO: For the arduino device
    • ttyUSB_LIDAR: For the lidar scanner device.
  • Adds documentation.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
Fixes usb port names.
bc6c37c 
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone
Adds docs.
05d81d6 
Signed-off-by: Franco Cipollone <[email protected]>
jballoffet
jballoffet requested changes Sep 3, 2023
View reviewed changes
Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, PTAL. Thanks!

andino_hardware/README.md Outdated Show resolved Hide resolved
@francocipollone
Addresses Javi's comments.
67e0109 
Signed-off-by: Franco Cipollone <[email protected]>
jballoffet
jballoffet approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@francocipollone francocipollone merged commit d90723a into humble Sep 3, 2023
3 checks passed
@francocipollone francocipollone deleted the francocipollone/fix_raspi_usb_port_names branch September 3, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jballoffet jballoffet jballoffet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Andino Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide documentation about usb devices ordering on raspi
2 participants
@francocipollone @jballoffet