Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4: Azure OpenAI Client Init #57

Merged
merged 9 commits into from
Jan 5, 2024
Merged

#4: Azure OpenAI Client Init #57

merged 9 commits into from
Jan 5, 2024

Conversation

mkrueger12
Copy link
Contributor

No description provided.

@mkrueger12 mkrueger12 self-assigned this Jan 2, 2024
@mkrueger12 mkrueger12 linked an issue Jan 2, 2024 that may be closed by this pull request
defaultParams := DefaultParams()

return &Config{
BaseURL: "", // This needs to come from config
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can this come from Config?

@mkrueger12 mkrueger12 changed the title #4: Azure OpenAI Client #4: Azure OpenAI Client Init Jan 2, 2024
@mkrueger12 mkrueger12 marked this pull request as ready for review January 3, 2024 23:18
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (4b66e2f) 66.14% compared to head (2825234) 71.12%.

❗ Current head 2825234 differs from pull request most recent head b721fe3. Consider uploading reports for the commit b721fe3 to get more accurate results

Files Patch % Lines
pkg/providers/azureopenai/chat.go 80.45% 18 Missing and 8 partials ⚠️
pkg/providers/azureopenai/config.go 61.29% 12 Missing ⚠️
pkg/providers/azureopenai/client.go 91.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #57      +/-   ##
===========================================
+ Coverage    66.14%   71.12%   +4.97%     
===========================================
  Files           11       14       +3     
  Lines          449      651     +202     
===========================================
+ Hits           297      463     +166     
- Misses         128      157      +29     
- Partials        24       31       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkrueger12 mkrueger12 marked this pull request as draft January 4, 2024 20:45
@mkrueger12 mkrueger12 marked this pull request as ready for review January 5, 2024 02:15
@mkrueger12 mkrueger12 merged commit faf0e42 into develop Jan 5, 2024
5 of 6 checks passed
@mkrueger12 mkrueger12 deleted the 4-azure-openai-client branch January 5, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Azure OpenAI Client
1 participant