Fix: Close dropdown on Shift + Tab and enable cyclic navigation for menu items. #940
+18
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Toggle Dropdown on Shift+Tab Behavior & Cyclic Navigation
true
, cyclic navigation is enabled.false
orunset
, the behavior remains unchanged.GITHUB ISSUE (Open Source Contributors)
NA
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-118833
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Toggle Dropdown on Shift+Tab
toggleDropdownOnShiftTab ={false}
to dropdown componentScreen.Recording.2025-02-04.at.5.16.08.PM.mov
Enabling Cyclic Navigation in Dropdown
applyCyclicNavigation={true}
to the List/Menu component.Screen.Recording.2025-02-06.at.2.51.57.PM.mov