Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][TM-oncall]: Upload container max width 100% #939

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

rkondra-eightfold
Copy link
Contributor

SUMMARY:

  • Fix max width on Large dropzone container
  • Before vs after
Screenshot 2025-02-03 at 8 49 55 PM Screenshot 2025-02-03 at 8 49 41 PM

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-126557

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Screenshot 2025-02-03 at 8 49 55 PM Screenshot 2025-02-03 at 8 49 41 PM

Copy link

codesandbox-ci bot commented Feb 3, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (e790948) to head (c375653).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #939   +/-   ##
=======================================
  Coverage   84.47%   84.47%           
=======================================
  Files        1100     1100           
  Lines       20513    20513           
  Branches     7759     7759           
=======================================
  Hits        17329    17329           
  Misses       3097     3097           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkondra-eightfold
Copy link
Contributor Author

:shipit:

@rkondra-eightfold rkondra-eightfold merged commit 437cbb8 into main Feb 4, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants