Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow generating css sourcemaps #891

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

anema-eightfold
Copy link

@anema-eightfold anema-eightfold commented Sep 12, 2024

SUMMARY

Allow generating proper SCSS/CSS sourcemaps

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Build octuple with GENERATE_SOURCEMAPS=1 yarn run build:webpack command & it should pass

Copy link

codesandbox-ci bot commented Sep 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (254ccfc) to head (69779fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   84.66%   84.66%           
=======================================
  Files        1099     1099           
  Lines       20416    20416           
  Branches     7718     7718           
=======================================
  Hits        17285    17285           
  Misses       3044     3044           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant