Skip to content

Commit

Permalink
Fix: SB does not scroll down with 50 records (adempiere#1590)
Browse files Browse the repository at this point in the history
  • Loading branch information
elsiosanchez authored Nov 2, 2023
1 parent 9b11cd0 commit 33bfeb7
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 4 deletions.
1 change: 1 addition & 0 deletions src/components/ADempiere/DataTable/Browser/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
:current-page="currentPage"
:selection="selectionsLength"
:records-page="recordsWithFilter.length"
:is-showed-selected="true"
:handle-change-page="handleChangePage"
:handle-size-change="handleChangeSizePage"
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ export default defineComponent({
default: (recordPrevious) => {
console.info('implement method Change to Previous Record ', recordPrevious)
}
},
isShowedSelected: {
type: Boolean,
default: false
}
},
Expand Down Expand Up @@ -152,6 +156,7 @@ export default defineComponent({
})
const isShowedTableRecords = computed(() => {
if (props.isShowedSelected) return props.isShowedSelected
return store.getters.getStoredTab(
parentUuid,
containerUuid
Expand Down
4 changes: 2 additions & 2 deletions src/store/modules/ADempiere/browserManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,8 @@ const browserControl = {
commit('setBrowserData', {
containerUuid,
recordsList,
recordCount: browserSearchResponse.recordCount,
nextPageToken: browserSearchResponse.nextPageToken,
recordCount: browserSearchResponse.record_count,
nextPageToken: browserSearchResponse.next_page_token,
pageNumber,
pageSize,
isLoaded: true
Expand Down
2 changes: 1 addition & 1 deletion src/utils/ADempiere/references.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const DEFAULT_SIZE = {
xl: 6
}

export const RECORD_ROWS_BY_LIST = 100
export const RECORD_ROWS_BY_LIST = 15

// Account Element
export const ACCOUNT_ELEMENT = {
Expand Down
2 changes: 1 addition & 1 deletion src/views/ADempiere/Browser/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
</collapse-criteria>
<br>
</div>
<div id="browser-table" style="height: inherit;">
<div id="browser-table">
<!-- Result of Records in the Table -->
<default-table
id="mainBrowser"
Expand Down

0 comments on commit 33bfeb7

Please sign in to comment.