Skip to content

Commit

Permalink
Addressed PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Frost45 committed Sep 27, 2022
1 parent a3c74c2 commit dbc39e2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions tests/test_bert_embedder.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def test_end_to_end(self):
assert list(bert_vectors.shape) == [2, 10, 768]

def test_max_length(self):
"""Test that max input length works."""
"""Test that max input length works (default max len = 512)."""

token_embedder = PretrainedBertEmbedder(
self.model_name,
Expand All @@ -206,7 +206,7 @@ def test_max_length(self):
token_embedder(tokens["bert"], tokens["bert-offsets"])

def test_max_length_raise_error(self):
"""Test that input greater than max length raises error."""
"""Test that input greater than max length (default = 512) raises error."""

token_embedder = PretrainedBertEmbedder(
self.model_name,
Expand Down
4 changes: 2 additions & 2 deletions tests/test_roberta_embedder.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def test_end_to_end(self):
assert list(bert_vectors.shape) == [2, 10, 768]

def test_max_length(self):
"""Test that max input length works."""
"""Test that max input length works (default max len = 512)."""

token_embedder = PretrainedBertEmbedder(
self.model_name,
Expand All @@ -191,7 +191,7 @@ def test_max_length(self):
token_embedder(tokens["bert"], tokens["bert-offsets"])

def test_max_length_raise_error(self):
"""Test that input greater than max length raises error."""
"""Test that input greater than max length (default = 512) raises error."""

token_embedder = PretrainedBertEmbedder(
self.model_name,
Expand Down

0 comments on commit dbc39e2

Please sign in to comment.