Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update crypto helpers to work in browser-compatible ways #7

Merged
merged 2 commits into from
Jul 31, 2024
Merged

update crypto helpers to work in browser-compatible ways #7

merged 2 commits into from
Jul 31, 2024

Conversation

tmountjr
Copy link
Collaborator

  • conditionally import the correct crypto module based on the presence of window
  • remove use of base64url from all Buffer operations and convert the string either to or from base64url-style encoding before using fully-supported base64 encoding

@tmountjr
Copy link
Collaborator Author

should fix #6

@tmountjr tmountjr linked an issue Jul 31, 2024 that may be closed by this pull request
library in current form does not work when used as a module on a web project #6
Closed
@tmountjr tmountjr merged commit 531f757 into main Jul 31, 2024
1 check passed
@tmountjr tmountjr deleted the issue-6 branch July 31, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

library in current form does not work when used as a module on a web project
1 participant
@tmountjr