Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displaying psalm issue line numbers #149

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Fix displaying psalm issue line numbers #149

merged 1 commit into from
Aug 6, 2018

Conversation

ndench
Copy link
Contributor

@ndench ndench commented Aug 6, 2018

Psalm seems to have changed the schema of it's xml report. Instead of containing line_number and column it now has line_to and line_from, which means we currently get a html report that looks like:

2018-08-06_14-54-13

This update shows the line numbers like:

2018-08-06_14-53-25

@zdenekdrahos
Copy link
Member

Introduced a long time ago in v1.0.0 (v0.3.93, commit).
So no backward compatibility is necessary.

@zdenekdrahos zdenekdrahos merged commit cc2a6bf into EdgedesignCZ:master Aug 6, 2018
@zdenekdrahos
Copy link
Member

Thanks @ndench

@ndench ndench deleted the fix-psalm-line-number branch August 6, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndench @zdenekdrahos