Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide options from config file #175

Closed
jonhattan opened this issue Jul 12, 2019 · 2 comments
Closed

Provide options from config file #175

jonhattan opened this issue Jul 12, 2019 · 2 comments

Comments

@jonhattan
Copy link

I'm not clear why some settings are provided as options (cli arguments) and other ones as config (.phpqa.yml). I guess there're historical reasons.

It would be handy to allow providing options from config file, so all settings are self-contained.

@zdenekdrahos
Copy link
Member

  • CLI options configure used tools, common analyzed and ignored directories
  • .phpqa.yml contains specific configuration for each tool.

I'd like to keep CLI options because:

I want to analyze selected directory without complex configuration and creating extra files/tasks
https://github.com/EdgedesignCZ/phpqa#why

I don't want to add more specific CLI options. That's configured in .phpqa.yml. I am not a fan of tool-specific CLI options, like in rclone.

Specific CLI options in rclone

@jonhattan
Copy link
Author

I think I didn't explain it well - I'd like to pick options from a config file if not provided in cli (I think you understood the opposite).

My primary use case is to set the analyzed/ignored files in .phpqa.yml along with the extensions.

Here's a PR that works for me: #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants