Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit fails with spaces in configuration file path #136

Closed
auroraeosrose opened this issue Jun 26, 2018 · 0 comments
Closed

PHPUnit fails with spaces in configuration file path #136

auroraeosrose opened this issue Jun 26, 2018 · 0 comments

Comments

@auroraeosrose
Copy link

The phpunit tool setup does not properly escape the filename of the configuration file

This makes any path with spaces fail - fix is pretty simple

https://github.com/EdgedesignCZ/phpqa/blob/master/src/Tools/Analyzer/Phpunit.php#L21

should be

$args['configuration'] = \Edge\QA\escapePath($configFile);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@auroraeosrose