Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

[feat/fix]: Use ASCII code for the exempt-issue-labels and more #2250

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

Panquesito7
Copy link
Member

What does this PR do?

  • Use ASCII code for the exempt-issue-labels setting and update the action to be the v4 version.
    • It seems the exempt-issue-labels setting doesn't work if you use spaces on it, thus, I'm using %20 which is interpreted as a space.

Description of the task to be completed?

None.

How can this be manually tested?

This would have to be tested once this workflow runs OR we could run it in my fork removing the cron.

Any background context you want to provide?

Nope.

Is there any relevant issue to this PR?

#108.

Questions

None.

...setting and update the action to be the v4 version.
It seems the `exempt-issue-labels` setting doesn't work if you use spaces on it, thus, I'm using `%20` which is interpreted as a space.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@eddiejaoude eddiejaoude merged commit 1110397 into EddieHubCommunity:main Aug 27, 2021
@Panquesito7 Panquesito7 deleted the fix_stale branch August 27, 2021 22:22
@schmelto
Copy link
Contributor

schmelto commented Aug 29, 2021

still not working.. :/
see #1744

@Panquesito7
Copy link
Member Author

actions/stale#98
Seems it's "fixed" but still not working.

We could actually just remove the %20 and try it just like that. We were using an old version of the stale bot, so that could've been the problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants