Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

"github-hover-white" #316

Closed

Conversation

PeacefulWrath
Copy link

@PeacefulWrath PeacefulWrath commented Mar 29, 2023

github card animation is now white in dark mode on hover

fix: #315

@PeacefulWrath PeacefulWrath marked this pull request as ready for review March 29, 2023 06:38
@@ -26,7 +26,7 @@

<style lang="postcss">
.card:hover::before {
@apply absolute -z-10 h-[500px] w-[100px] bg-[#24292f];
@apply absolute -z-10 h-[500px] w-[100px] bg-[#ffffff];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to differentiate between light and dark mode. Now it's working for dark mode, but in light mode, it's nearly not visible

Copy link
Author

@PeacefulWrath PeacefulWrath Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it..thanks for point it out

@PeacefulWrath
Copy link
Author

@Cahllagerfeld i just want to know how to use dark property in postcss??

@Cahllagerfeld
Copy link
Member

according to the tailwind docs [1] you can use dark: to access the styles for dark-theme

@Cahllagerfeld
Copy link
Member

Let me know if you need further help here

@ghost
Copy link

ghost commented May 28, 2023

Can anybody suggest me some beginner friendly issue? I am new to open source and github.

@Cahllagerfeld
Copy link
Member

closing this due to inactivity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] Improve animation color of github of techstack in dark mode
2 participants