Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lists getters #1

Merged
merged 5 commits into from
Sep 3, 2016
Merged

Add Lists getters #1

merged 5 commits into from
Sep 3, 2016

Conversation

apocheau
Copy link
Contributor

I added the ability to retreive informations about a specific list or list all lists.
Just pay attention to the "ListInfo.modules" array, which is not implemented.

import com.ecwid.maleorang.annotation.*

/**
* [Get information about a specific list]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be no space or newline here, as it breaks the link in Dokka

@basiliscus
Copy link

Hi apocheau,

Thank you for the contribution. I've left some comments and will merge the changes as soon as the issues fixed.

@apocheau
Copy link
Contributor Author

Hello basiliscus and thanks for your reply.
It's the first time i use Kotlin so i appreciated your observations and will follow your guidelines.
For modules, i'll try to find more info about it, otherwise, i'll remove it.
It seems there is a lack of information about this field:

http://developer.mailchimp.com/documentation/mailchimp/reference/lists/#read-get_lists_list_id
"modules": {
"type": "array",
"title": "Modules",
"description": "Any list-specific modules installed for this list.",
"readonly": true,
"example": [
""
],
"links": null
}

Finally, do you have kind of roadmap or stuff you are working on ?

@basiliscus
Copy link

Finally, do you have kind of roadmap or stuff you are working on ?

No, I do not have any plans on improving the library. However, contributions are welcome: I will be merging pull requests and releasing new versions.

Fix Dokka document
Remove Modules field
@basiliscus basiliscus merged commit 0490408 into Ecwid:master Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants