Voronoi #30 #46
Voronoi #30 #46
Conversation
src/algorithms/discretevoronoi.jl
Outdated
|
|
||
| DiscreteVoronoi() = DiscreteVoronoi(3) | ||
|
|
||
| function _landscape!(mat, alg::DiscreteVoronoi) |
There was a problem hiding this comment.
Couldn't this whole function just be
_landscape!(mat, alg::DiscreteVoronoi) = _landscape!(mat, NearestNeighborElement(alg.n, 1))end of story?
There was a problem hiding this comment.
Indeed. We probably don't need to reimplement. Just add in documentation that NearestNeighborElement with k set at 1 is voronoi-like.
There was a problem hiding this comment.
Basically, I was just looking for a way to rasterize a Voronoi (#30). Now I know it's super easy using NearestNeighborElement, we can close the issue 👍
There was a problem hiding this comment.
Ah no, I think it's great to have a wrapper for this! i just wanted to reuse the function we already had. I think it should work if you edit the PR as suggested :-)
There was a problem hiding this comment.
Sorry I wasn't clear what I meant by "reimplement"
src/algorithms/discretevoronoi.jl
Outdated
| end | ||
| end | ||
|
|
||
| DiscreteVoronoi() = DiscreteVoronoi(3) |
There was a problem hiding this comment.
why not just add 3 as a default value in the internal constructor in line 9?
There was a problem hiding this comment.
oh nice. I see
src/algorithms/discretevoronoi.jl
Outdated
| """ | ||
| DiscreteVoronoi | ||
|
|
||
| Assigns a value to each patch using a 1-NN algorithmm with `n` initial clusters |
There was a problem hiding this comment.
This doesn't explain why it's called "Voronoi"
There was a problem hiding this comment.
Nice @virgile-baudrot looks good - thanks for the contribution!
Add Discrete Voronoi generation using NearestNeighborElement #30
Type of change
Please indicate the relevant option(s)
Checklist
.zenodo.jsonProject.tomlfieldversionhas been updatedv0.0.xseries release, a bug fix, or a performance improvement