Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaner distance code #20

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Conversation

mkborregaard
Copy link
Member

@mkborregaard mkborregaard commented Feb 14, 2021

I think I edited the code for clarity. It is also like twice as fast for rand on a 1000 x 1000 matrix. Note that this is made against #13

@mkborregaard mkborregaard requested a review from tpoisot February 14, 2021 10:18
@codecov-io
Copy link

codecov-io commented Feb 14, 2021

Codecov Report

Merging #20 (20bc74f) into feature/DistanceGradient (0904cf2) will increase coverage by 2.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feature/DistanceGradient      #20      +/-   ##
============================================================
+ Coverage                     36.36%   38.46%   +2.09%     
============================================================
  Files                             8        8              
  Lines                            55       52       -3     
============================================================
  Hits                             20       20              
+ Misses                           35       32       -3     
Flag Coverage Δ
unittests 38.46% <0.00%> (+2.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/algorithms/distancegradient.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0904cf2...20bc74f. Read the comment docs.

@tpoisot
Copy link
Contributor

tpoisot commented Feb 14, 2021

I really need to read the Iterators documentation...

@tpoisot tpoisot merged commit 6e2d955 into feature/DistanceGradient Feb 14, 2021
@mkborregaard mkborregaard deleted the mkb/clean_distance branch February 15, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants