Improvement: Add get_cp_state method to iso15118 interface controller and include cp_status handler #77
Conversation
| f"waiting for C2 or D2" | ||
| ) | ||
| # wait for state C or D 250ms | ||
| await asyncio.sleep(0.25) |
There was a problem hiding this comment.
Just so I understand this correctly - is this 250ms from the specification? Or do we actually have a little less than 3 seconds to detect state C2 or D2?
There was a problem hiding this comment.
this is from spec req number V2G2-847. << The EV shall signal CP State C or D no later than 250ms after sending the first PowerDeliveryReq with ChargeProgress equals "Start" within V2G Communication SessionPowerDeliveryReq. >>
There was a problem hiding this comment.
Okie dokie...a comment with the spec reference would be nice here?
There was a problem hiding this comment.
Done, actually, it was there, I just rearranged it.
| f"waiting for C2 or D2" | ||
| ) | ||
| # wait for state C or D 250ms | ||
| await asyncio.sleep(0.25) |
There was a problem hiding this comment.
Okie dokie...a comment with the spec reference would be nice here?
ikaratass
changed the title
ikaratass
force-pushed
the
cs_status
branch
2 times, most recently
from
4a92c81 to
88d8bac
Compare
|
I missed to add this comment - would be good to add a reference to [V2G2-847] - "The EV shall signal CP State C or D no later than 250ms after sending the first PowerDeliveryReq with ChargeProgress equals "Start" within V2G Communication SessionPowerDeliveryReq." where we have the 250ms sleep. |
unitest for cp_state
ikaratass
force-pushed
the
cs_status
branch
from
d76e808 to
5a8142c
Compare
| @pytest.mark.parametrize( | ||
| "get_state_return_value, expected_next_state", | ||
| [ | ||
| (CpState.C2, CurrentDemand), |
There was a problem hiding this comment.
Would be good to check C1, D1 ends up in Terminate as well
| @@ -1554,6 +1565,32 @@ async def process_message( | |||
|
|
|||
| self.expecting_power_delivery_req = False | |||
|
|
|||
| async def wait_for_state_c_or_d(self) -> bool: | |||
| STATE_C_TIMEOUT = 0.25 | |||
There was a problem hiding this comment.
Would be good to mention [V2G2-847] as the reason for 0.25.
improvement on AB#2162