fix: authorization state enum #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrinagordon-believ
requested review from
tropxy,
snorkman88,
mdwcrft and
shalinnijel2
shalinnijel2
suggested changes
May 27, 2022
Also, since we are required to use American English spelling
("authorization") by the ISO 15118 spec, standardize on this in our own
usage as well.
sabrinagordon-believ
force-pushed
the
fix/authorization-state-enum/1668
branch
from
b887106 to
6660d67
Compare
sabrinagordon-believ
force-pushed
the
fix/authorization-state-enum/1668
branch
from
dd53698 to
3f60b1e
Compare
tropxy
requested changes
May 30, 2022
shalinnijel2
approved these changes
Jun 1, 2022
tropxy
approved these changes
Jun 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the true/false return value for
is_authorizedwith Accepted/Rejected/Ongoing, since an AuthorizationReq can be retried to deal with the time limit imposed by ISO 15118-2.This also adds some unit tests and replaces a repeatedly-used test value with a constant.