Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVCC enable charging and fix for DIN EVSE initiated stop #368

Merged
merged 7 commits into from
Jan 23, 2024
Merged

EVCC enable charging and fix for DIN EVSE initiated stop #368

merged 7 commits into from
Jan 23, 2024

Conversation

heavyweight87
Copy link
Contributor

@heavyweight87 heavyweight87 commented Jan 21, 2024 •
edited
Loading

Fixes #356 and #264

  • Added enable_charging to evcc controller interface. This gives the EVCC the opertunity to go to state C (or B)
  • Fixed an issue where the wrong flag was checked when receiving current demand response for EVSE initiated shutdown (DIN only)

@heavyweight87 heavyweight87 mentioned this pull request Jan 21, 2024
Closed
@shalinnijel2
Copy link
Contributor

@heavyweight87 - thank you for opening this PR. :). Just noticed one thing - calling enable_charging(True) in -20 was missed.
Call enable_charging(True) just above the below lines if charge progress is set to START to cater for both AC and DC?
https://github.com/SwitchEV/iso15118/blob/b3f3a6233c4cf1c3d434c7926f4056f4a271f107/iso15118/evcc/states/iso15118_20_states.py#L858
https://github.com/SwitchEV/iso15118/blob/b3f3a6233c4cf1c3d434c7926f4056f4a271f107/iso15118/evcc/states/iso15118_20_states.py#L1579

@shalinnijel2
Copy link
Contributor

The following commands would help identify any linting issues:

make flake8
make black
make reformat

@heavyweight87
Copy link
Contributor Author

@heavyweight87 - thank you for opening this PR. :). Just noticed one thing - calling enable_charging(True) in -20 was missed. Call enable_charging(True) just above the below lines if charge progress is set to START to cater for both AC and DC?

https://github.com/SwitchEV/iso15118/blob/b3f3a6233c4cf1c3d434c7926f4056f4a271f107/iso15118/evcc/states/iso15118_20_states.py#L858

https://github.com/SwitchEV/iso15118/blob/b3f3a6233c4cf1c3d434c7926f4056f4a271f107/iso15118/evcc/states/iso15118_20_states.py#L1579

Ah how did I miss that! Thanks - added and also fixed the linter problem!

heavyweight87 added 2 commits January 23, 2024 08:31
@heavyweight87
Copy link
Contributor Author

The test was using the old method of stopping charging - now fixed and hopefully should pass the test.

shalinnijel2
shalinnijel2 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@shalinnijel2 shalinnijel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shalinnijel2 shalinnijel2 merged commit 43ee0a6 into EcoG-io:master Jan 23, 2024
1 check passed
@shalinnijel2
Copy link
Contributor

I'm merging this to master. I'll close the other two related tickets as well. Feel free to reopen if there is more to add.

@shalinnijel2 shalinnijel2 mentioned this pull request Jan 23, 2024
Closed
@notion-workspace Notion Workspace
Copy link

In DINSPEC use EVSEStatusCode to initiate ending of a charging session from SECC side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalinnijel2 shalinnijel2 shalinnijel2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

evse_notification incorrectly used to detect shutdown request from EVSE in dinspec
2 participants
@heavyweight87 @shalinnijel2